Add tvOS support. Close #118 #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jessesquires updated the pull request - view changes |
|
@jessesquires updated the pull request - view changes |
1 similar comment
|
All green 🎉 |
|
You're all crushing it omg |
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 16, 2016
Summary: - Created a new workspace for tvOS examples w/ Cocoapods & dependency on IGListKit - Created a demo chooser across the same lines as the iOS equivalent - Duplicated the 'Nested Adapter' example from iOS pack to the tvOS example - Uses native navigation to get around, created focus/active states for cells - Updated `travis.yml` to optionally build tvOS example pack Note: Not added any imagery/icons/etc due to the much larger & different sizes required - If they're desired then someone with skills will need to provide them! Closes #138 Relates to #137 - [x] All tests pass. Demo project builds and runs. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md) Closes #141 Differential Revision: D4189645 Pulled By: rnystrom fbshipit-source-id: 7a2b8e7a50ed2a9bbbf68d5f446a4e0077214ffa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Closes #118.
IGListKit-tvOSPodfileand.podspec.travis.ymlCHANGELOGREADMEpod installand check-in updatesPull request checklist