Skip to content

DOC: Added a hint for future developers #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

DOC: Added a hint for future developers #108

merged 1 commit into from
Mar 6, 2025

Conversation

@hjmjohnson
Copy link
Member

@hjmjohnson hjmjohnson commented Feb 1, 2025

No description provided.

@hjmjohnson hjmjohnson requested review from dzenanz and thewtex February 1, 2025 15:45
dzenanz
dzenanz reviewed Feb 1, 2025
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but Matt should review, too.

@hjmjohnson hjmjohnson force-pushed the update-to-allow-ci-passing branch from 6366a05 to bdc6af9 Compare February 2, 2025 14:31
@hjmjohnson
Copy link
Member Author

hjmjohnson commented Feb 2, 2025

@thewtex -- @dzenanz requested your review.

dzenanz
dzenanz approved these changes Feb 2, 2025
View reviewed changes
@dzenanz
Copy link
Member

dzenanz commented Feb 4, 2025

Trying to use this here, I run into:

Run sudo xcode-select -s "/Applications/Xcode_15.0.1.app"
  sudo xcode-select -s "/Applications/Xcode_15.0.1.app"
  shell: /bin/bash -e {0}
xcode-select: error: invalid developer directory '/Applications/Xcode_15.0.1.app'
Error: Process completed with exit code 1.

and into:

HEAD is now at ca1a7e5 ENH: Only extract required directories from the ITKPythonBuilds tar
HEAD detached at ca1a7e5
nothing to commit, working tree clean
~/work/ITKMontage/ITKMontage
ERROR: can not find required binary './ITKPythonPackage/scripts/dockcross-manylinux-build-module-wheels.sh'
Building module wheels
./dockcross-manylinux-download-cache-and-build-module-wheels.sh: line 76: ./ITKPythonPackage/scripts/dockcross-manylinux-build-module-wheels.sh: No such file or directory
Error: Process completed with exit code 127.

@hjmjohnson hjmjohnson force-pushed the update-to-allow-ci-passing branch 2 times, most recently from 3e5b39f to f80ec68 Compare February 4, 2025 22:06
thewtex
thewtex requested changes Feb 7, 2025
View reviewed changes
@hjmjohnson hjmjohnson force-pushed the update-to-allow-ci-passing branch from f80ec68 to a0d4c71 Compare March 5, 2025 20:57
dzenanz
dzenanz approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dzenanz
dzenanz approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzenanz dzenanz requested a review from thewtex March 5, 2025 21:03
thewtex
thewtex requested changes Mar 6, 2025
View reviewed changes
thewtex
thewtex reviewed Mar 6, 2025
View reviewed changes
@hjmjohnson hjmjohnson force-pushed the update-to-allow-ci-passing branch from a0d4c71 to c40ef4e Compare March 6, 2025 12:33
@hjmjohnson hjmjohnson requested a review from thewtex March 6, 2025 13:13
thewtex
thewtex requested changes Mar 6, 2025
View reviewed changes
@hjmjohnson hjmjohnson force-pushed the update-to-allow-ci-passing branch 2 times, most recently from fd92eb5 to d600e21 Compare March 6, 2025 14:40
@hjmjohnson hjmjohnson requested a review from thewtex March 6, 2025 14:42
@hjmjohnson hjmjohnson changed the title COMP: Update the CI package dependancies. DOC: Added a few hints for future developers, updated main hash Mar 6, 2025
@hjmjohnson hjmjohnson force-pushed the update-to-allow-ci-passing branch from d600e21 to 2ddcf5c Compare March 6, 2025 14:46
@hjmjohnson
DOC: Justify exclusion of 3.12 and 3.13 build
633592d 
Minimizing the explicit build list greatly reduces the
CI burdens for testing resources.

Python 3.12 and 3.13 aim to maintain ABI compatibility with Python 3.11
through the Stable ABI. Extensions compiled against the Python 3.11 ABI
should, in principle, continue to work without recompilation in Python
3.12 and 3.13.

However, relying on the Stable ABI doesn't guarantee
complete compatibility, as behavioral changes or bug fixes in newer
Python versions can still affect extension behavior. It is recommended
to rebuild extensions for each major Python version to ensure optimal
compatibility and to take advantage of any potential performance
improvements.
@hjmjohnson hjmjohnson force-pushed the update-to-allow-ci-passing branch from 2ddcf5c to 633592d Compare March 6, 2025 14:46
@hjmjohnson hjmjohnson changed the title DOC: Added a few hints for future developers, updated main hash DOC: Added a hint for future developers Mar 6, 2025
thewtex
thewtex approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @hjmjohnson

@thewtex thewtex merged commit f664f77 into main Mar 6, 2025
1 check passed
@thewtex thewtex deleted the update-to-allow-ci-passing branch March 6, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hjmjohnson @dzenanz @thewtex