Skip to content

Added the date information of Chinese translation and reviewing #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2023
Merged

Added the date information of Chinese translation and reviewing #516

merged 2 commits into from
Jan 3, 2023

Conversation

WillemJiang
Copy link
Collaborator

No description provided.

@WillemJiang WillemJiang requested a review from yuhattor as a code owner January 3, 2023 09:09
@WillemJiang WillemJiang mentioned this pull request Jan 3, 2023
Merged
@spier spier changed the title Added the date information of translation and reviewing. Added the date information of Chinese translation and reviewing Jan 3, 2023
@spier spier added the Type - Translation Translating patterns into other languages label Jan 3, 2023
@spier
Copy link
Member

spier commented Jan 3, 2023

Will merge this as is.

I am confused that toc.md got updated, even though I don't see a change that would have triggered this.
Looks like the title of translation/zh/patterns/innersource-license.md changed in the TOC but I don't know why.

Will check this again on the target branch after merging.

@spier spier merged commit ea8d114 into InnerSourceCommons:book-zh Jan 3, 2023
@WillemJiang
Copy link
Collaborator Author

I am confused that toc.md got updated, even though I don't see a change that would have triggered this. Looks like the title of translation/zh/patterns/innersource-license.md changed in the TOC but I don't know why.

There is a space between the ‘内源 许可协议’ （Innersource and License).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spier spier spier approved these changes

@yuhattor yuhattor Awaiting requested review from yuhattor

Assignees
No one assigned
Labels
Type - Translation Translating patterns into other languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillemJiang @spier