Skip to content

[WIP] Spell check action #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[WIP] Spell check action #272

wants to merge 11 commits into from

Conversation

spier
Copy link
Member

@spier spier commented Jan 9, 2021

Experiment with spell checker action, related to #218

@spier
Copy link
Member Author

spier commented Jan 9, 2021

I am trying out this action at the moment reitermarkus/aspell.
There is also this one, which already seems to have some following: https://github.com/marketplace/actions/github-spellcheck-action

@spier spier changed the title Spell check action [WIP] Spell check action Jan 9, 2021
@lenucksi
Copy link
Member

I am trying out this action at the moment reitermarkus/aspell.
There is also this one, which already seems to have some following: https://github.com/marketplace/actions/github-spellcheck-action

Looks interesting, but can it also do PR annotation? I mean, I'll look into the CI logs, but not everyone will I guess.

@lenucksi lenucksi added the Type - Maintenance / Cleanup Maintaining / cleaning the repo is the main focus of this issue / PR label Jan 10, 2021
@spier
Copy link
Member Author

spier commented Jan 10, 2021

Yeah good question. I am playing with two different Actions here, and the 1st one shows inline annotations, for the 2nd one I couldn't figure it out yet.

@nschonni
Copy link
Contributor

I tend to use https://github.com/streetsidesoftware/cspell since it has good support in VS Code and CLI for CI. There is an Action, but I tend just to use the CLI directly

@spier
Copy link
Member Author

spier commented Jan 11, 2021

as good support in VS Code and CLI for CI. There is an Action, but I tend just to use the CLI directly

Thanks for the pointer.

From the first tests I don't see a clear path yet for how to make the spell checker functional across all of our text.

  • company names, people names
  • British English vs American English
  • colloquialism
  • random stuff (I would argue mistakes of the spell checkers)

Will do some more test.

Just like for the markdown linter it feels like it will be important in the configuration of the spell-checking to find a sensible balance between being to strict and too lax.

@nschonni
Copy link
Contributor

Looks interesting, but can it also do PR annotation? I mean, I'll look into the CI logs, but not everyone will I guess.

FYI, you can also create your own problem matchers when jobs don't exist for a particular tool. EX: https://github.com/w3c/aria-practices/blob/master/.github/workflows/cspell-problem-matcher.json and then register it https://github.com/w3c/aria-practices/blob/master/.github/workflows/spelling.yml#L44

AlexAndradeNet and others added 4 commits March 19, 2021 10:04
Contracted-contributor spell check
Crossteam project valuation spell check
Praise participantsspell check
Issue tracker spell check

Co-authored-by: Sebastian Spier <github@spier.hu>
@spier spier mentioned this pull request Mar 19, 2021
Improving spelling in "Communication Tooling" pattern.
@spier
Copy link
Member Author

spier commented Jan 13, 2023

#519 is superseding this PR here.

@spier spier closed this Jan 13, 2023
@spier spier deleted the spell-check-action branch January 13, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type - Maintenance / Cleanup Maintaining / cleaning the repo is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants