-
Notifications
You must be signed in to change notification settings - Fork 196
[WIP] Spell check action #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am trying out this action at the moment reitermarkus/aspell. |
Looks interesting, but can it also do PR annotation? I mean, I'll look into the CI logs, but not everyone will I guess. |
Yeah good question. I am playing with two different Actions here, and the 1st one shows inline annotations, for the 2nd one I couldn't figure it out yet. |
I tend to use https://github.com/streetsidesoftware/cspell since it has good support in VS Code and CLI for CI. There is an Action, but I tend just to use the CLI directly |
Thanks for the pointer. From the first tests I don't see a clear path yet for how to make the spell checker functional across all of our text.
Will do some more test. Just like for the markdown linter it feels like it will be important in the configuration of the spell-checking to find a sensible balance between being to strict and too lax. |
FYI, you can also create your own problem matchers when jobs don't exist for a particular tool. EX: https://github.com/w3c/aria-practices/blob/master/.github/workflows/cspell-problem-matcher.json and then register it https://github.com/w3c/aria-practices/blob/master/.github/workflows/spelling.yml#L44 |
Contracted-contributor spell check
Crossteam project valuation spell check
Praise participantsspell check
Issue tracker spell check Co-authored-by: Sebastian Spier <github@spier.hu>
Improving spelling in "Communication Tooling" pattern.
#519 is superseding this PR here. |
Experiment with spell checker action, related to #218