Skip to content

Conversation

@AlexAndradeNet
Copy link
Contributor

No description provided.

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what feedback the author's provide about the changes to the Patlet.

I also reverted a couple of other changes that you made, in cases where I was reasonably sure that the original version was correct.

@spier
Copy link
Member

spier commented Mar 19, 2021

@AlexAndradeSan thank you for all your fantastic work on improving the spelling of the InnerSource patterns.

I have already merged most of your PRs, keeping the remaining 2 PRs open to get some feedback from you or the original authors of the patterns.

One general question:
I noticed (a bit too late unfortunately) that your PRs were targeting the spell-check-action branch, rather than the master branch. Was there any particular reason for this?

The spell-check-action branch was created as part of an experiment in #272 and it might not get merge into master in the near future.

But no problem at all, after all your PRs are merged into spell-check-action, I will make sure to get all of your spelling fixes ported over into master.

And yet another thing:
If you would like to chat more with other InnerSource practitioners, there is this slack channel that you can join if you like.

@spier spier self-assigned this Mar 19, 2021
@spier
Copy link
Member

spier commented Mar 24, 2021

hi @AlexAndradeSan. Just wanted to check in again to ask if you saw my last comment above? ⬆️

@spier
Copy link
Member

spier commented May 1, 2021

Hi @AlexAndradeSan, I am getting back to this PR now, to see if we can get these changes merged?
Note that in the meantime we have renamed our mainline branch to main, which is where we would like to merge these changes into.

@spier
Copy link
Member

spier commented May 15, 2021

Status update:
I have ported most of your other fixes in to main via PR #327.

Might later also revert those changes from the spell-check-action branch, as they don't really belong there.

@spier
Copy link
Member

spier commented Jul 4, 2021

Hi @AlexAndradeSan. Based on the feedback about the Patlet of this pattern from @MaineC, I made a proposal for what I think will be an easier to understand variant of this Patlet.

I also reviewed all of your other changes in this PR again, and they look good. Thanks again for your help here!

Once you confirm that this looks ok, then I will merge these changes (FYI I will create a new PR for this, as we need the changes to be merged into the main branch, rather than the spell-check-action branch).

Co-authored-by: Sebastian Spier <github@spier.hu>
Copy link
Contributor Author

@AlexAndradeNet AlexAndradeNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the suggestions

spier added a commit that referenced this pull request Jul 5, 2021
@spier spier mentioned this pull request Jul 5, 2021
@spier
Copy link
Member

spier commented Jul 5, 2021

Closing this PR in favor of #334

@spier spier closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants