-
Couldn't load subscription status.
- Fork 202
Maturity model.md #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maturity model.md #315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see what feedback the author's provide about the changes to the Patlet.
I also reverted a couple of other changes that you made, in cases where I was reasonably sure that the original version was correct.
|
@AlexAndradeSan thank you for all your fantastic work on improving the spelling of the InnerSource patterns. I have already merged most of your PRs, keeping the remaining 2 PRs open to get some feedback from you or the original authors of the patterns. One general question: The But no problem at all, after all your PRs are merged into And yet another thing: |
|
hi @AlexAndradeSan. Just wanted to check in again to ask if you saw my last comment above? ⬆️ |
|
Hi @AlexAndradeSan, I am getting back to this PR now, to see if we can get these changes merged? |
|
Status update: Might later also revert those changes from the spell-check-action branch, as they don't really belong there. |
|
Hi @AlexAndradeSan. Based on the feedback about the Patlet of this pattern from @MaineC, I made a proposal for what I think will be an easier to understand variant of this Patlet. I also reviewed all of your other changes in this PR again, and they look good. Thanks again for your help here! Once you confirm that this looks ok, then I will merge these changes (FYI I will create a new PR for this, as we need the changes to be merged into the |
Co-authored-by: Sebastian Spier <github@spier.hu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the suggestions
|
Closing this PR in favor of #334 |
No description provided.