Skip to content

pattern/badly-named-piles #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2017
Merged

pattern/badly-named-piles #14

merged 4 commits into from
Feb 2, 2017

Conversation

gruetter
Copy link
Contributor

@gruetter gruetter commented Dec 7, 2016

Hi everyone. Here's another pattern from the wiki for PR review.

ErinMB and others added 2 commits December 7, 2016 08:22
Added a bullet point in the solutions section regarding labels. Use of labels has been suggested to me by GitHub as part of the solution for this, but I haven't explored the best way to implement yet. Updated a couple of other lines in this same section.
@nyeates nyeates changed the title Badly Named Piles Pattern/Badly Named Piles Jan 17, 2017
@nyeates nyeates changed the title Pattern/Badly Named Piles pattern/badly-named-piles Jan 19, 2017
@nyeates nyeates added Draft and removed Idea labels Feb 2, 2017
Copy link
Contributor

@nyeates nyeates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. I was about to add a solution around having a dedicated role to sort out project metadata - and now I see it in the final bullet.

@nyeates nyeates merged commit fc67089 into master Feb 2, 2017
@nyeates nyeates deleted the pattern/badly-named-piles branch February 2, 2017 06:27
spier pushed a commit that referenced this pull request Dec 29, 2022
* Added the translation of praise participant

* Fixed a markdownlint error of praise-participants

* Updated the translation with review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants