IEA #97
IEA #97
Conversation
|
Fantastic. Thanks a lot. Any tests you could add? |
|
What kind of tests are you thinking? |
|
In test_functionality.py you find some example (e.g. test_fao_number_codes). Please remove vscode (put in gitignore). sorry, i need to better explain the contribution. The branch "release_test" is an internal branch for testing release to pypi (to pypitesting). A change to master would be highly appreciate, but I can also solve on my side. I might wait for the merge one or two days, I want to show Mohammed and Candy how this works (thanks for the example 👏🏽 ) ; unless you need that urgently |
|
Ah I see. What do you mean by "Please remove vscode (put in gitignore)". It should already be in .gitignore? I am no sure if you would like me to do anything now? Should I make a pull request to the master branch or will you do that yourself at some point? And how should I interpret the build error above? Something I should worry about or is that fine? |
|
thanks a lot 👍🏽 |
* update changelog * added link to example script for parsing data * vscode ignore in gitignore * Mamba GitHub actions (#98) - switched github actions to development and production - testing on different os * IEA (#97) * added IEA classification * Added IEA to README.rst Co-authored-by: Kajwan Rasul <kajwan.rasul@ntnu.no> * fixed country data missing NA * updated CHANGELOG for new release * updated CHANGELOG for new release * new version * Added EXIOBASE 3 letter codes (#100) Added 3 letter codes for EXIOBASE 1, 2 and 3 with various test cases Co-authored-by: Konstantin Stadler <konstantin.stadler@ntnu.no> * IEA update and bug fix (#109) * wrapped spec_name in re.escape() allows for countries to have names with regular expression characters, such as parenthesis or dots. * bug in pd max_rows Returned 'Pattern matched multiple keys' option error * ran black properly now Co-authored-by: Kajwan Rasul <kajwan.rasul@ntnu.no> * update changelog * pump version * pump version * Changed to Türkiye and North Macedonia - fix #110 * Fix Bassas Da India - fix #111 * black formating * Add oecd dac (closes #101) (#102) * Added OECD DAC code classification to country_data.tsv * Add DACcode to README.rst * Add DACcode test to test_functionality.py * update test_functionality.py Missing white space at 662 for black test to pass successfully * Update country_data.tsv * Update country_data.tsv * N Korea match North Korea #95 * Converted md files to rst * Allow regex in ISO2 - fix #92 * rerun notebooks * regex for iso * changelog and new version test * removed rst from links * fix markdown render for pypi Co-authored-by: Kajwan <34449043+Kajwan@users.noreply.github.com> Co-authored-by: Kajwan Rasul <kajwan.rasul@ntnu.no> Co-authored-by: Mohamed Badr <62759252+MohamedhBadr@users.noreply.github.com> Co-authored-by: Jorge Rivera <jorge.rivera@one.org>
Added IEA classification.