Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update India regex to avoid matching Bassas Da India #111

Closed
mcarans opened this issue Jul 26, 2022 · 2 comments
Closed

Update India regex to avoid matching Bassas Da India #111

mcarans opened this issue Jul 26, 2022 · 2 comments

Comments

@mcarans
Copy link
Contributor

mcarans commented Jul 26, 2022 •
edited
Loading

I would like to suggest updating the India regex to avoid matching "Bassas Da India", a French atoll that is part of the French Southern and Antarctic Lands.
@mcarans
Copy link
Contributor Author

mcarans commented Jul 26, 2022

After some experimenting, I think this will work:
^(?!\D*(?:bassas))\D*india(?!.*ocea)(?!na)

@konstantinstadler
Copy link
Member

Thanks a lot! will be added in the new release in the next days

konstantinstadler added a commit that referenced this issue Aug 3, 2022
@konstantinstadler @Kajwan
@MohamedhBadr @jm-rivera
test new readme format (#112)
b2111b0 
* update changelog

* added link to example script for parsing data

* vscode ignore in gitignore

* Mamba GitHub actions (#98)

- switched github actions to development and production
- testing on different os

* IEA (#97)

* added IEA classification

* Added IEA to README.rst

Co-authored-by: Kajwan Rasul <kajwan.rasul@ntnu.no>

* fixed country data missing NA

* updated CHANGELOG for new release

* updated CHANGELOG for new release

* new version

* Added EXIOBASE 3 letter codes (#100)

Added 3 letter codes for EXIOBASE 1, 2 and 3 with various test cases

Co-authored-by: Konstantin Stadler <konstantin.stadler@ntnu.no>

* IEA update and bug fix (#109)

* wrapped spec_name in re.escape()

allows for countries to have names with regular expression characters, such as parenthesis or dots.

* bug in pd max_rows

Returned 'Pattern matched multiple keys' option error

* ran black properly now

Co-authored-by: Kajwan Rasul <kajwan.rasul@ntnu.no>

* update changelog

* pump version

* pump version

* Changed to Türkiye and North Macedonia - fix #110

* Fix Bassas Da India - fix #111

* black formating

* Add oecd dac (closes #101) (#102)

* Added OECD DAC code classification to country_data.tsv

* Add DACcode to README.rst

* Add DACcode test to test_functionality.py

* update test_functionality.py

Missing white space at 662 for black test to pass successfully

* Update country_data.tsv

* Update country_data.tsv

* N Korea match North Korea #95

* Converted md files to rst

* Allow regex in ISO2 - fix #92

* rerun notebooks

* regex for iso

* changelog and new version test

* removed rst from links

* fix markdown render for pypi

Co-authored-by: Kajwan <34449043+Kajwan@users.noreply.github.com>
Co-authored-by: Kajwan Rasul <kajwan.rasul@ntnu.no>
Co-authored-by: Mohamed Badr <62759252+MohamedhBadr@users.noreply.github.com>
Co-authored-by: Jorge Rivera <jorge.rivera@one.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcarans @konstantinstadler