-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LayerStructure updates for abiotic_simple #448
Merged
davidorme
merged 4 commits into
421-additional-information-in-layerstructure
from
446-fixing-abiotic_simple-for-441
Jun 21, 2024
Merged
LayerStructure updates for abiotic_simple #448
davidorme
merged 4 commits into
421-additional-information-in-layerstructure
from
446-fixing-abiotic_simple-for-441
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
davidorme
commented
Jun 18, 2024
davidorme
commented
Jun 18, 2024
vgro
reviewed
Jun 19, 2024
vgro
reviewed
Jun 19, 2024
vgro
reviewed
Jun 19, 2024
vgro
reviewed
Jun 19, 2024
@davidorme thanks for your help with this, it looks really good, a few minor tweaks. I'll finish the hydrology stuff that I started yesterday and then I'll make the changes here, I'll let you know when I need you to review again. |
vgro
reviewed
Jun 19, 2024
…fixing-abiotic_simple-for-441
davidorme
changed the base branch from
develop
to
421-additional-information-in-layerstructure
June 21, 2024 09:37
The |
davidorme
merged commit Jun 21, 2024
f52c4a9
into
421-additional-information-in-layerstructure
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces changes to make the
abiotic_simple
model work with the new LayerStructure in #421.@vgro - if you can have a look at the changes to see if anything looks mad (but the tests pass, so hopefully not) then I can merge it down into #421.
The main changes to the actual code are passing
LayerStructure
down the chain rather thanlayer_roles
and then using that functionality.Fixes #446
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks