Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayerStructure updates for abiotic_simple #448

Conversation

davidorme
Copy link
Collaborator

@davidorme davidorme commented Jun 18, 2024

Description

This PR introduces changes to make the abiotic_simple model work with the new LayerStructure in #421.

@vgro - if you can have a look at the changes to see if anything looks mad (but the tests pass, so hopefully not) then I can merge it down into #421.

The main changes to the actual code are passing LayerStructure down the chain rather than layer_roles and then using that functionality.

Fixes #446

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@davidorme davidorme linked an issue Jun 18, 2024 that may be closed by this pull request
@davidorme davidorme requested a review from vgro June 18, 2024 09:40
@vgro
Copy link
Collaborator

vgro commented Jun 19, 2024

@davidorme thanks for your help with this, it looks really good, a few minor tweaks. I'll finish the hydrology stuff that I started yesterday and then I'll make the changes here, I'll let you know when I need you to review again.

@davidorme davidorme changed the base branch from develop to 421-additional-information-in-layerstructure June 21, 2024 09:37
@davidorme
Copy link
Collaborator Author

The abiotic_simple tests all pass locally, which is the point of this subbranch, so merging it down into #421.

@davidorme davidorme merged commit f52c4a9 into 421-additional-information-in-layerstructure Jun 21, 2024
2 of 4 checks passed
@davidorme davidorme deleted the 446-fixing-abiotic_simple-for-441 branch June 21, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing abiotic_simple for #441
2 participants