Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional information in LayerStructure #421

Closed
vgro opened this issue May 2, 2024 · 0 comments · Fixed by #441
Closed

Additional information in LayerStructure #421

vgro opened this issue May 2, 2024 · 0 comments · Fixed by #441
Milestone
Core structures

Comments

@vgro
Copy link
Collaborator

vgro commented May 2, 2024

There are a number of static properties of our 3D structure that we use to create arrays, select indices etc, for example the topsoil_layer_index, number of layers above ground, and so on.

I suggest that we add these static properties to the LayerStructure so they are easier accessible and the same across all models.
@davidorme davidorme added this to the Core structures milestone Jun 4, 2024
@davidorme davidorme mentioned this issue Jun 12, 2024
Merged
15 tasks
@davidorme davidorme linked a pull request Jun 12, 2024 that will close this issue
Amending vertical layer structure #441
Merged
15 tasks
This was referenced Jun 18, 2024
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Merged
This was referenced Jul 18, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Core structures
Development

Successfully merging a pull request may close this issue.

Amending vertical layer structure ImperialCollegeLondon/virtual_ecosystem
2 participants
@davidorme @vgro