Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/radiation dummy 2 #155

Closed
wants to merge 456 commits into from
Closed

Feature/radiation dummy 2 #155

wants to merge 456 commits into from

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented Jan 27, 2023

Description

This is a new clean PR for the radiation submodule including all changes that were requested up to last week in PR #130.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

jacobcook1995 and others added 30 commits January 18, 2023 13:38
@jacobcook1995
Added sanity checks for obviously bad but hard to spot input
a103e88
@jacobcook1995
Fixed minor issue with using any rather than np.any
01fdd56
@jacobcook1995
Switched to new api docs structure
9cf48f2
@vgro
attributes defined in docstrings, types removed
142db39
@vgro
constant import test updated
c14e3d3
@davidorme
Import pyplot in sphinx conf.py to force font cache build before note…
d6d9b36 
…books
@davidorme
Rogue out of date TODO
58ebe3d
@davidorme
Made variable name less opaque
b26090c
@davidorme
Remove generic AxisValidator method descriptions - describe ABC and s…
66ee947 
…ubclass methods independently
@davidorme
Made variable name less opaque
92ef6cf
@davidorme
Draft restructure of AxisValidator doc structure
f9cbff4
@davidorme
Syntax fixes and bullet list confusion
a9a547b
@davidorme
More bullet list confusion
fbf5554
@davidorme
Updated docstrings on remaining AxisValidator subclasses
8738378
@davidorme
Fixing code-blocks in data/readers
0ff07a7
@davidorme
Syntax fixes and clarification
00ec6e2
@davidorme
Class attribute docstrings AxisValidators, beefed up setting and test…
9f42b3d 
…ing of same
@davidorme
Updated attribute docstrings on data.Data
1993e72
@davidorme
Updated user docs for core.data to add example of other methods
c9e4161
@davidorme
More clarity (hopefully) in core axis description for users
5109003
@davidorme
Extended and clarified API docs on core.data
6230af4
@dalonsoa
Update .readthedocs.yaml
6fb4822
@davidorme
Merge pull request #145 from ImperialCollegeLondon/dalonsoa-patch-1
39aff5a 
Solve issue with documentation not rendering properly
@jacobcook1995
Does python 3.9.16 work for windows yet
e9af928
@jacobcook1995
Does macosx work for 3.9 and 3.10 now?
ec45f98
@jacobcook1995
Removed comment which I missed
bff89c1
@jacobcook1995
Merge pull request #146 from ImperialCollegeLondon/ci_python_version_…
1df932d 
…patch

Unpinning CI python versions as no longer needed
@jacobcook1995
Merge branch 'develop' into feature/dummy_carbon
e934c0a 
Making sure latest doc changes are in my dummy carbon branch
@jacobcook1995
Caught pinned python version I previously missed
21d5e0d
@davidorme
Clarify cell_id coordinates in userdocs
398c70a
davidorme and others added 27 commits February 13, 2023 14:19
@davidorme
Turning on nitpicky and intersphinx
862cca0
@vgro
Update base_model.py
3f2d05d 
minor typo fixed
@davidorme
Fixing abiotic refs in api and module
72bf12a
@davidorme
Merge branch 'feature/update_api_links' of https://github.com/Imperia…
872853e 
…lCollegeLondon/virtual_rainforest into feature/update_api_links
@davidorme
Broken links in data and readers
f7c4655
@davidorme
Line length issue
d5857c7
@davidorme
Broken links in readers.py
5e3bde7
@jacobcook1995
First attempt to fix broken links in config.py
de8b6fb
@jacobcook1995
Merging David's changes into my local branch
3e22b3e
@davidorme
More broken links in data/axes/readers
fe74798
@davidorme
Broken special links in data
a95067b
@davidorme
Getting @jacobcook1995 fixes
42aae2e
@davidorme
Fixed missing core API entry and moved docstrings to core.__init__.py
69d3a47
@jacobcook1995
Added a soil docs string to its __init__
50dd9c1
@jacobcook1995
Fixed remaining issues with abiotic docs links
9568153
@jacobcook1995
Added Draft202012Validator as something to be ignored by nitpick
99b8185
@jacobcook1995
Fixed broken link in soil api
e043348
@jacobcook1995
Changed reference to logger to fix broken link
9aabd11
@jacobcook1995
Fixed broken dostring links for base_model
baefdde
@jacobcook1995
Fixed another couple of bad links
52bb9d8
@jacobcook1995
Fixed problem with using NDArray
e521e05
@jacobcook1995
Excluded numpy.float64
171d87e
@jacobcook1995
Added api documentation for soil constant dataclasses
695d0e6
@jacobcook1995
Added numpy.int64 to nitpick exclusions
4172747
@jacobcook1995
Merge pull request #177 from ImperialCollegeLondon/feature/update_api…
c311719 
…_links

API links updated to new model names
@vgro
Merge branch 'develop' into feature/radiation_dummy_2
4fc4577
@vgro
updated links and reference to base_model
c943dfb
@vgro vgro closed this Feb 16, 2023
@vgro
Copy link
Collaborator Author

vgro commented Feb 16, 2023

I will create a new PR to merge directly in develop, no need for intermediate feature branch

@vgro vgro mentioned this pull request Feb 16, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobcook1995 jacobcook1995 jacobcook1995 left review comments

@alexdewar alexdewar alexdewar requested changes

@dalonsoa dalonsoa dalonsoa requested changes

@davidorme davidorme Awaiting requested review from davidorme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vgro @davidorme @alexdewar @dalonsoa @codecov-commenter @jacobcook1995