Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpinning CI python versions as no longer needed #146

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

jacobcook1995
Copy link
Collaborator

Description

Github actions python versions for 3.9 and 3.10 now default to 3.9.16 and 3.10.9, respectively. This means there's no longer any reason to keep the versions pinned, so I have unpinned them. (They were originally pinned to fix a weird CI edge case where a specific test would fail on macOS for python versions <3.9.16 and <3.10.9)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Might as well remove out of date comment too

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #146 (bff89c1) into develop (39aff5a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #146   +/-   ##
========================================
  Coverage    94.06%   94.06%           
========================================
  Files           11       11           
  Lines          472      472           
========================================
  Hits           444      444           
  Misses          28       28           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobcook1995 jacobcook1995 merged commit 1df932d into develop Jan 23, 2023
@jacobcook1995 jacobcook1995 deleted the ci_python_version_patch branch January 23, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants