Skip to content

Conversation

@fedorov
Copy link
Member

@fedorov fedorov commented Sep 30, 2023

  • fix plastimatch install
  • switch to s5cmd for download
  • fix few smaller issues

@denbonte can you please fix pyplastimatch viz part?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@denbonte
Copy link
Contributor

denbonte commented Oct 1, 2023

@fedorov I opened a PR to the fix-segprimer branch on fedorov/IDC-Tutorials (I forked it, edited it under my account, and opened a PR).

I guess this is the right way to co-author a PR with forks (I've never done it this way) - but let me know if it's not. I think you should be able to merge my PR to your forked repo/branch, and the changes will then show up here as part of the PR to the IDC-Tutorials repo.

If this is not the case, please - feel free to open my notebook in Colab, edit whatever still needs to be edited, push it to your fork, and then merge it to the IDC-Tutorials repo through this PR. I don't mind, as long as it works 🙃

@denbonte denbonte marked this pull request as ready for review October 1, 2023 03:45
@denbonte denbonte marked this pull request as draft October 1, 2023 03:45
Minor fixes to the Segmentation Primer Notebook
@fedorov fedorov marked this pull request as ready for review October 1, 2023 03:51
@fedorov fedorov merged commit fa6d221 into ImagingDataCommons:master Oct 1, 2023
@fedorov fedorov mentioned this pull request Oct 2, 2023
@fedorov fedorov deleted the fix-segprimer branch November 20, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants