Skip to content

Conversation

@denbonte
Copy link

@denbonte denbonte commented Oct 1, 2023

As discussed, here's a brief list of the fixes to the notebook:

  • If I got your intentions right, this cell should have a try-except and not an if-else (the cell fails to run and throws an error if result doesn't exist; I know that's not the case, but if a user were to run the whole notebook with "run all" this would break it!)
  • I fixed the widgets, which are now working again (I changed the module name from viz to widgets in the bunch of commits I pushed before the release of pyplastimatch 0.4.3)
  • I changed the coding style a bit for consistency 🙃

@denbonte
Copy link
Author

denbonte commented Oct 1, 2023

I also removed the "Open to Colab" button at the top (GitHub now adds that automatically, so adding it in Colab makes it pop up twice when opened from GitHub - and you definitely don't need to see that button in Colab, since you're already in Colab).

Before:
image

After:
image

@fedorov fedorov merged commit 4cd6732 into fedorov:fix-segprimer Oct 1, 2023
fedorov pushed a commit that referenced this pull request Nov 20, 2023
commit outputs only on push or when triggered by scheduler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants