Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set entry->registered to TRUE when custom URI scheme handler is regis… #729

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Set entry->registered to TRUE when custom URI scheme handler is regis… #729

merged 1 commit into from
Aug 26, 2024

Conversation

ziebarthw
Copy link
Contributor

…tered

Sets the entry->registered flag to TRUE after registering the custom URI handler with WebKit.

Fixes #727

aperezdc
aperezdc approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@aperezdc aperezdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@aperezdc aperezdc added bug Something isn't working merge:cog-0.18 labels Aug 26, 2024
@aperezdc aperezdc merged commit 1866ef8 into Igalia:master Aug 26, 2024
5 checks passed
@aperezdc
Copy link
Member

Merged into the cog-0.18 branch as commit d51b26e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge:cog-0.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequestHandlerMapEntry->registered not being set to TRUE when handler is registered.
2 participants
@ziebarthw @aperezdc