Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestHandlerMapEntry->registered not being set to TRUE when handler is registered. #727

Closed
ziebarthw opened this issue Aug 21, 2024 · 0 comments · Fixed by #729
Closed

RequestHandlerMapEntry->registered not being set to TRUE when handler is registered. #727

ziebarthw opened this issue Aug 21, 2024 · 0 comments · Fixed by #729
Labels
bug Something isn't working

Comments

@ziebarthw
Copy link
Contributor

It appears RequestHandlerMapEntry->registered is not being set to TRUE in cog_shell.c:request_handler_map_entry_register() after webkit_web_context_register_uri_scheme() is called.

It's not a fatal error, but webkit_web_context_register_uri_scheme() does report an error if a program calls cog_shell_set_request_handler() and then calling cog_shell_startup().

Setting entry->registered to TRUE inside cog_shell.c:request_handler_map_entry_register() suppresses the error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set entry->registered to TRUE when custom URI scheme handler is regis… ziebarthw/cog
2 participants
@aperezdc @ziebarthw