Skip to content

Adds configuration directive for RequestedAuthnContext #806 #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pandafy
Copy link
Contributor

@pandafy pandafy commented May 31, 2021

Closes #806

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

TODO: Update documentation

@pandafy pandafy force-pushed the issues/806-requested-authn-context branch from d5687a2 to 4c30066 Compare May 31, 2021 13:38
peppelinux added a commit to IdentityPython/djangosaml2 that referenced this pull request Jun 2, 2021
* feat: sso_kwargs now handled with some custom methods ... that can be inherited :)
* feat: authn context support, with or without this IdentityPython/pysaml2#807 (better with!)
* feat: authn context documentation
peppelinux added a commit to IdentityPython/djangosaml2 that referenced this pull request Jun 4, 2021
* SAML2 Request improved

* feat: sso_kwargs now handled with some custom methods ... that can be inherited :)
* feat: authn context support, with or without this IdentityPython/pysaml2#807 (better with!)
* feat: authn context documentation

* fix: Documentation for developers, unit tests

* v1.3.0
@c00kiemon5ter c00kiemon5ter force-pushed the issues/806-requested-authn-context branch 3 times, most recently from 507a3fc to 55127f0 Compare October 20, 2021 07:17
Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
@c00kiemon5ter c00kiemon5ter force-pushed the issues/806-requested-authn-context branch from 55127f0 to d1a11db Compare October 20, 2021 07:23
@c00kiemon5ter
Copy link
Member

c00kiemon5ter commented Oct 20, 2021

I've updated this and the config looks like this:

    "service": {
        "sp": {
            "requested_authn_context": {
                "authn_context_class_ref": [
                    "urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport",
                    "urn:oasis:names:tc:SAML:2.0:ac:classes:TLSClient",
                ],
                "comparison": "minimum",
            }
        }
    }

Internally this is converted to a proper object and serialized as XML as part of the AuthnRequest.

/cc @pandafy @peppelinux

@peppelinux
Copy link
Member

thank you @c00kiemon5ter
djangosaml2 is resilient on breaking changes related to this feature because it adopts a custom way to handle this behaviour.
I think that your proposal is better than before, so feel free to merge it asap, I'll do my updates in djangosaml2 by my side

@pandafy ^

@c00kiemon5ter c00kiemon5ter merged commit 9f30f2f into IdentityPython:master Oct 20, 2021
peppelinux added a commit to IdentityPython/djangosaml2 that referenced this pull request Nov 16, 2021
- feat: conf.py takes sp_kwargs to extend the customization of unit tests
- chore: RequestedAuthnContext updated to pysaml2 7.1 (IdentityPython/pysaml2#807)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration directive for RequestedAuthnContext
3 participants