Skip to content

Authn Context and general SAML2 Request improvement #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2021
Merged

Authn Context and general SAML2 Request improvement #289

merged 1 commit into from
Jun 4, 2021

Conversation

peppelinux
Copy link
Member

This PR closes https://github.com/IdentityPython/djangosaml2/pull/288/files

just add this in SAML_CONFIG['service']['sp']

            'requested_authn_context': {
                'authn_context_class_ref': saml2.saml.AUTHN_PASSWORD_PROTECTED,
                'comparison': "exact"
            }

@peppelinux
SAML2 Request improved
c97924d 
* feat: sso_kwargs now handled with some custom methods ... that can be inherited :)
* feat: authn context support, with or without this IdentityPython/pysaml2#807 (better with!)
* feat: authn context documentation
@peppelinux peppelinux requested a review from c00kiemon5ter June 2, 2021 21:44
@peppelinux peppelinux mentioned this pull request Jun 2, 2021
Closed
pandafy
pandafy reviewed Jun 3, 2021
View reviewed changes
djangosaml2/views.py
Comment on lines +170 to +171
def load_sso_kwargs(self, sso_kwargs):
""" Inherit me if you want to put your desidered things in sso_kwargs """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I was thinking of making sso_kwargs a class attribute but this is better. I had to make more changes in the Login views to support more configuration attributes but this will simplify it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KISS Is the way 👈

pandafy
pandafy approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@pandafy pandafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@peppelinux peppelinux merged commit ca724eb into dev Jun 4, 2021
@peppelinux peppelinux mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandafy pandafy pandafy approved these changes

@c00kiemon5ter c00kiemon5ter Awaiting requested review from c00kiemon5ter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peppelinux @pandafy