Skip to content

Fix crash when notifications are sent while the notification object is deleted (2.11) #8780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2021
Merged

Fix crash when notifications are sent while the notification object is deleted (2.11) #8780

merged 1 commit into from
May 26, 2021

Conversation

julianbrost
Copy link
Contributor

backport of #8591

@icinga-probot icinga-probot bot added area/distributed Distributed monitoring (master, satellites, clients) area/notifications Notification events consider backporting Should be considered for inclusion in a bugfix release core/crash Shouldn't happen, requires attention labels May 20, 2021
@julianbrost julianbrost removed the consider backporting Should be considered for inclusion in a bugfix release label May 20, 2021
@julianbrost julianbrost added this to the 2.11.9 milestone May 20, 2021
@julianbrost julianbrost force-pushed the bugfix/concurent-notification-send-and-delete-2.11 branch from dd319a8 to 63596a1 Compare May 21, 2021 16:07
@julianbrost
Use reference-counted pointer in notification callback
9060264 
`this` could be deleted after `Notification::BeginExecuteNotification`
exited and before `Notification::ExecuteNotificationHelper` finished.
This is fixed by constructing a `Notification::Ptr` and operate on that
one as it is properly reference-counted.
@julianbrost julianbrost force-pushed the bugfix/concurent-notification-send-and-delete-2.11 branch from 63596a1 to 9060264 Compare May 26, 2021 06:53
@julianbrost julianbrost requested a review from Al2Klimov May 26, 2021 08:52
@Al2Klimov Al2Klimov merged commit 031f379 into support/2.11 May 26, 2021
@icinga-probot icinga-probot bot deleted the bugfix/concurent-notification-send-and-delete-2.11 branch May 26, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al2Klimov Al2Klimov Al2Klimov approved these changes

Assignees
No one assigned
Labels
area/distributed Distributed monitoring (master, satellites, clients) area/notifications Notification events core/crash Shouldn't happen, requires attention
Projects
None yet
Milestone
2.11.9
Development

Successfully merging this pull request may close these issues.
2 participants
@julianbrost @Al2Klimov