Fix crash when notifications are sent while the notification object is deleted #8591
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icinga-probot
bot
added
area/distributed
Al2Klimov
requested changes
Jan 11, 2021
`this` could be deleted after `Notification::BeginExecuteNotification` exited and before `Notification::ExecuteNotificationHelper` finished. This is fixed by constructing a `Notification::Ptr` and operate on that one as it is properly reference-counted.
julianbrost
force-pushed
the
bugfix/concurent-notification-send-and-delete
branch
from
1b4918a to
aea06a2
Compare
Al2Klimov
approved these changes
Jan 12, 2021
| @@ -431,7 +431,11 @@ void Notification::BeginExecuteNotification(NotificationType type, const CheckRe | |||
| << "Sending " << (reminder ? "reminder " : "") << "'" << NotificationTypeToString(type) << "' notification '" | |||
| << notificationName << "' for user '" << userName << "'"; | |||
|
|
|||
| Utility::QueueAsyncCallback(std::bind(&Notification::ExecuteNotificationHelper, this, type, user, cr, force, author, text)); | |||
| // Explicitly use Notification::Ptr to keep the reference counted while the callback is active | |||
| Notification::Ptr notification (this); | |||
There was a problem hiding this comment.
Pro tip: Due to the context you could also just use Ptr as type. But I don’t demand that.
icinga-probot
bot
deleted the
bugfix/concurent-notification-send-and-delete
branch
julianbrost
added
the
consider backporting
This was referenced May 20, 2021
N-o-X
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending notifications, an asynchronous callback is scheduled which captures the
thispointer which is not reference-counted. This PR fixes this by using a reference-countedNotification::Ptrinstead.fixes #8587