-
Notifications
You must be signed in to change notification settings - Fork 0
Ticket 8731 alerts dialog #1800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...c.isis.ibex.configserver/src/uk/ac/stfc/isis/ibex/configserver/displaying/DisplayAlerts.java
Dismissed
Show dismissed
Hide dismissed
...c.isis.ibex.configserver/src/uk/ac/stfc/isis/ibex/configserver/displaying/DisplayAlerts.java
Dismissed
Show dismissed
Hide dismissed
...c.isis.ibex.configserver/src/uk/ac/stfc/isis/ibex/configserver/displaying/DisplayAlerts.java
Dismissed
Show dismissed
Hide dismissed
...c.isis.ibex.configserver/src/uk/ac/stfc/isis/ibex/configserver/displaying/DisplayAlerts.java
Dismissed
Show dismissed
Hide dismissed
...c.isis.ibex.configserver/src/uk/ac/stfc/isis/ibex/configserver/displaying/DisplayAlerts.java
Dismissed
Show dismissed
Hide dismissed
...bex.configserver/src/uk/ac/stfc/isis/ibex/configserver/displaying/TopLevelAlertSettings.java
Dismissed
Show dismissed
Hide dismissed
...bex.configserver/src/uk/ac/stfc/isis/ibex/configserver/displaying/TopLevelAlertSettings.java
Dismissed
Show dismissed
Hide dismissed
...bex.configserver/src/uk/ac/stfc/isis/ibex/configserver/displaying/TopLevelAlertSettings.java
Dismissed
Show dismissed
Hide dismissed
...c.stfc.isis.ibex.ui.alerts/src/uk/ac/stfc/isis/ibex/ui/alerts/dialogs/AlertsEditorPanel.java
Show resolved
Hide resolved
...c.stfc.isis.ibex.ui.alerts/src/uk/ac/stfc/isis/ibex/ui/alerts/dialogs/AlertsEditorPanel.java
Fixed
Show fixed
Hide fixed
2 tasks
LowriJenkins
requested changes
Aug 4, 2025
Contributor
LowriJenkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All works fine, fix the code ql problems and missing new lines and then this all looks good
...c.stfc.isis.ibex.alerts.tests/src/uk/ac/stfc/isis/ibex/alerts/tests/AlertsActivatorTest.java
Outdated
Show resolved
Hide resolved
...k.ac.stfc.isis.ibex.alerts.tests/src/uk/ac/stfc/isis/ibex/alerts/tests/AlertsSetterTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@LowriJenkins , added NL and some of the Code QL. Most of the suggested changes are not required. |
LowriJenkins
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR covers the GUI work for configuring Alerts.
Ticket
The requirements are defined here
Acceptance criteria
Code Review
check_opi_format.pyscript in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?Final Steps