Skip to content

Conversation

@Chsudeepta
Copy link
Contributor

Description of work

This PR covers the GUI work for configuring Alerts.

Ticket

The requirements are defined here

Acceptance criteria

  • The GUI code should build from the command prompt (..\build\build.bat)
  • The GUI should provide an easy and intuitive mechanism to configure alert details.
  • The GUI should give ability to change the block level alert values after selecting the block.
  • The GUI should give a separate section to see and alter the global alert values (emails, mobiles and message).
  • The emails and mobiles should be first shown masked and remain so unless they are changed.
  • The GUI shouldn't allow users to add incorrect values and show proper error message/guidance.
  • It should be possible to add multiple emails and mobiles.
  • It should be possible to generate, if required, and send an alert message from the GUI.

Code Review

Final Steps

Copy link
Contributor

@LowriJenkins LowriJenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works fine, fix the code ql problems and missing new lines and then this all looks good

@Chsudeepta
Copy link
Contributor Author

@LowriJenkins , added NL and some of the Code QL. Most of the suggested changes are not required.

@LowriJenkins LowriJenkins merged commit 0e2187b into master Aug 5, 2025
8 checks passed
@LowriJenkins LowriJenkins deleted the Ticket_8731_Alerts_Dialog branch August 5, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants