20 user facing dae #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkeymer
reviewed
Sep 27, 2024
davidkeymer
reviewed
Sep 27, 2024
davidkeymer
reviewed
Sep 27, 2024
rerpha
reviewed
Oct 1, 2024
Tom-Willemsen
force-pushed
the
20_user_facing_dae
branch
from
cffd856 to
091cdbd
Compare
Contributor
iangillingham-stfc
left a comment
iangillingham-stfc
left a comment
There was a problem hiding this comment.
Just a handful of pedantic type incompatibilities and a function which 'could' be static.
Integration testing on a dev system worked well.
iangillingham-stfc
approved these changes
Oct 1, 2024
Contributor
iangillingham-stfc
left a comment
iangillingham-stfc
left a comment
There was a problem hiding this comment.
My previous questions re base class / derived class function return types has been answered and mitigated my the function decorators, which change the return types accordingly.
The function identified as could be static should remain as instance function as it uses self in derived classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
Needs these PRs to be merged first: