Skip to content

Conversation

@FreddieAkeroyd
Copy link
Member

@FreddieAkeroyd FreddieAkeroyd commented Sep 10, 2024

See ISISComputingGroup/IBEX#8499

This PR also improves NORD readback behaviour

Copy link
Contributor

@iangillingham-stfc iangillingham-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@FreddieAkeroyd
Copy link
Member Author

Hi, mine does this if there is a mismatch in ISISICP version or registration. Did you update ISISICP via update_dev.bat as per ISISComputingGroup/IBEX#8499 including doing the register_server as admin bit it mentions at the end?

@FreddieAkeroyd
Copy link
Member Author

Actually, i've noticed that the admin register bit was commented out of update_dev as it didn't work at that point due to different paths, i've now fixed that so you should run update_dev again and this time there should be a register program to run. Registration only needs to be redone if a new function is added to the interface, last time that happened was three years ago so not very often

@iangillingham-stfc
Copy link
Contributor

 C:\Instrument\Dev\ibex_bluesky_core :: 20_user_facing_dae                                   |  ibex_bluesky_core | 15:42:49
➜ caget TE:NDW2920:DAE:SPEC:0:1:XE.NORD
TE:NDW2920:DAE:SPEC:0:1:XE.NORD 50

 C:\Instrument\Dev\ibex_bluesky_core :: 20_user_facing_dae                                   |  ibex_bluesky_core | 15:43:00
➜ caget TE:NDW2920:DAE:SPEC:0:1:X.NORD
TE:NDW2920:DAE:SPEC:0:1:X.NORD 50

Shouldn't XE have size one more than X?

@FreddieAkeroyd
Copy link
Member Author

It should indeed. It was been fixed before and not updating if the spectrum changed size (which doesn't usually happen, but i though i should allow for it). However when i added the automatic update, i didn't add the +1 to that. Now resolved.

@iangillingham-stfc iangillingham-stfc merged commit 9e54dae into master Oct 1, 2024
@iangillingham-stfc iangillingham-stfc deleted the fix_period_uah_update branch October 1, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants