Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6684 dataset pg btn responsive #6909

Merged
merged 66 commits into from
Jun 11, 2020
Merged

Conversation

mheppler
Copy link
Contributor

@mheppler mheppler commented May 12, 2020

What this PR does / why we need it:

  • action btns on dataset and file pg need more scalable space
  • primary actions on dataset and file pg need to be more prominent
  • responsive layout on dataset and file pg needs to be improved
  • need a lil more color on dataset and file pg

Which issue(s) this PR closes:

Closes #6684 Layout and styling of action buttons on the dataset and file page
Closes #3815 Improve visibility of buttons for data owners
Closes #1664 Dataset Publish/Submit for Review - Optimize Button/Popup Code
Closes #1221 Deaccessioning: What should show in search card?
Closes #1063 Mobile Dataverse: Solution for Displaying Dataverse on a Mobile Device

Ref #6605 Dataset Page Redesign
Ref #6604 File Page Redesign
Ref #3953 Improve the clarity of page types and their purpose

Special notes for your reviewer:

Thank you for your time.

Suggestions on how to test this:

@kcondon, I would be happy to meet and discuss what I should put here to help you.

Does this PR introduce a user interface change?:

Well, yeah. (Link to mockups: https://sketch.cloud/s/mWGQJ/a/4KZgLZ)

Is there a release notes update needed for this change?:

N/A

Additional documentation:

N/A

mheppler and others added 30 commits March 12, 2020 12:08
That's seemingly a lot of changes, but it was the assumption throughout the code base that
all the dataset-level thumbnails are always the same size. Removing it now will help with
making all the thumbnails for everything completely variable (as opposed to how they come in
the few pre-defined sizes now), which we are planning to add as well, sometime soon (?)
ref #6684
@mheppler
Copy link
Contributor Author

mheppler commented Jun 4, 2020

@sekmiller contributed a bunch of render logic optimization code, moving a lot of the render logic of the publish/submit for review links/buttons from the XHTML to the DatasetPage.java backing bean. There is now only one publish commandLink in the new button UI xhtml code.

@kcondon, with these improvements, I have linked issue Dataset Publish/Submit for Review - Optimize Button/Popup Code #1664 to be closed when this PR is merged.

@djbrooke
Copy link
Contributor

djbrooke commented Jun 8, 2020

Discussed briefly in the design meeting. The steps remaining here are:

@mheppler
Copy link
Contributor Author

mheppler commented Jun 8, 2020

Fixed (a16adff) the merge conflict/broken dataset pg added in the last update from develop, related to request access javascript that was added by @qqmyers #6943. (Hope that I didn't break anything even more!)

In order to make sure his new code was delivered to both the dataset pg and file pg, I had to duplicate that code block, since we don't have a very elegant way of delivering two different looking buttons to two different pages in the new button UI.

@mheppler
Copy link
Contributor Author

mheppler commented Jun 8, 2020

OK. Back to QA.

Thank you for the refactored publish btn and popup code, @sekmiller. The old #1664 issue reporting that has been linked to the original PR comment above to close it.

I also had to back out an unnecessary duplication of javascript that I added in my last merge conflict fix and referenced in my last comment above.

@mheppler mheppler removed their assignment Jun 8, 2020
@kcondon kcondon self-assigned this Jun 11, 2020
@kcondon
Copy link
Contributor

kcondon commented Jun 11, 2020

Issues found:
x 1. Button color scheme no longer blue as in mockups. This may have been a late stage change.
Intentionally done to reduce broad impact of changes in ui. Access btn is blue.
x 2. Publish btn disappears during publish when published version exists, not on initial publish, likely due to existing draft ver bug. This is related to an existing bug so n/a for this pr.
x 3. Exception on dataset publish, dataset does publish.
Caused by: java.lang.NullPointerException
at edu.harvard.iq.dataverse.DataFile.getDerivedOriginalFileName(DataFile.java:425)
at edu.harvard.iq.dataverse.DataFile.getOriginalFileName(DataFile.java:416)
Could not reproduce but is an uncommon, preeexisting issue.

@kcondon kcondon merged commit 3eb3d47 into develop Jun 11, 2020
@kcondon kcondon deleted the 6684-dataset-pg-btn-responsive branch June 11, 2020 17:24
@djbrooke djbrooke added this to the Dataverse 5 milestone Jun 16, 2020
pdurbin added a commit that referenced this pull request Aug 24, 2021
This reverts 95d7e04 which was part of pull request #6909 for #6684.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment