Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default thumbnail size #6769

Closed
scolapasta opened this issue Mar 25, 2020 · 10 comments
Closed

Change default thumbnail size #6769

scolapasta opened this issue Mar 25, 2020 · 10 comments
Milestone

Comments

@scolapasta
Copy link
Contributor

For the upcoming dataset page redesign, thumbnails will be displayed in a larger form. However, the currently created thumbnails don't scale well to this new size. This issue is to:
• change the size for which thumbnails are created to 140x140 (@TaniaSchlatter please verify this the size we want)
• regenerate existing thumbnail

@scolapasta
Copy link
Contributor Author

Note, we will eventually want the ability to produce thumbnails of different sizes (see issue #5679) but this is a smaller, quicker chunk to unblock this aspect of the redesign.

@pdurbin
Copy link
Member

pdurbin commented Apr 14, 2020

I just pushed 17c3891 to change 64 to 140 and here's a visual of how a dataset page looks:

Screen Shot 2020-04-14 at 11 50 17 AM

Note that the trees next to the title are as small as ever. The trees in the file listing (and the other file) are now 140 pixels wide and covering up the file name.

I'll probably jump in #dv-design for clarification of what's desired.

@mheppler
Copy link
Contributor

Added max-width:64px; max-height:64px; to the stylesheet in order to apply size dimensions to the file thumbnail on the dataset pg (file table), upload/edit files pg, replace file pg.

@mheppler mheppler removed their assignment Apr 15, 2020
@mheppler
Copy link
Contributor

Had a good call with @pdurbin to move this issue forward, which ended up being an unintentional code review.

Recommended changes include:

  • revert CSS fix that I added for resizing the thumbnails images in the file table on the dataset pg
  • revert image size change added to DEFAULT_THUMBNAIL_SIZE on ImageThumbConverter.java
  • add new 140px image size to ImageThumbConverter class on ImageThumbConverter.java
  • change dataset pg related (DatasetWidgetsPage.java?, DatasetUtil.java?) DEFAULT_THUMBNAIL_SIZE references to to point to new 140px image size instead

Would then like to discuss with the team (tech hours?) + @djbrooke if we should move these changes to my branch in order to apply the necessary UI front-end/css changes required to support this larger dataset thumbnail image, or do we create a PR and move it to QA to merge without resolving the thumbnail overlapping content UI issue?

@djbrooke
Copy link
Contributor

@mheppler @pdurbin thanks for the discussion and for tagging me. Sounds like it's better if this is included in the buttons branch instead of as an independent PR.

@pdurbin
Copy link
Member

pdurbin commented Apr 16, 2020

@djbrooke ok, @mheppler suggested making a pull request against his branch, so I just did with pull request #6830.

@pdurbin pdurbin removed their assignment Apr 16, 2020
@djbrooke
Copy link
Contributor

@pdurbin cool, thanks!

@mheppler
Copy link
Contributor

Merged the PR from @pdurbin into my 6684-dataset-pg-btn-responsive branch. Will document these changes in issue #6684 for QA.

@mheppler
Copy link
Contributor

Additional revisions to this code from @landreev in 4254a0f.

@pdurbin pdurbin added this to the Dataverse 5 milestone Jul 17, 2020
@pdurbin
Copy link
Member

pdurbin commented Jul 17, 2020

This wasn't auto-closed by pull request #6830 so I'm closing it now.

@pdurbin pdurbin closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants