-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default thumbnail size #6769
Comments
Note, we will eventually want the ability to produce thumbnails of different sizes (see issue #5679) but this is a smaller, quicker chunk to unblock this aspect of the redesign. |
I just pushed 17c3891 to change 64 to 140 and here's a visual of how a dataset page looks: Note that the trees next to the title are as small as ever. The trees in the file listing (and the other file) are now 140 pixels wide and covering up the file name. I'll probably jump in #dv-design for clarification of what's desired. |
Added |
Had a good call with @pdurbin to move this issue forward, which ended up being an unintentional code review. Recommended changes include:
Would then like to discuss with the team (tech hours?) + @djbrooke if we should move these changes to my branch in order to apply the necessary UI front-end/css changes required to support this larger dataset thumbnail image, or do we create a PR and move it to QA to merge without resolving the thumbnail overlapping content UI issue? |
@pdurbin cool, thanks! |
This wasn't auto-closed by pull request #6830 so I'm closing it now. |
For the upcoming dataset page redesign, thumbnails will be displayed in a larger form. However, the currently created thumbnails don't scale well to this new size. This issue is to:
• change the size for which thumbnails are created to 140x140 (@TaniaSchlatter please verify this the size we want)
• regenerate existing thumbnail
The text was updated successfully, but these errors were encountered: