Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4139 curator edits in review #4208

Closed
wants to merge 18 commits into from
Closed

4139 curator edits in review #4208

wants to merge 18 commits into from

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Oct 16, 2017 •
edited
Loading

Related Issues

Pull Request Checklist

@pdurbin
assert current behavior: curator can't edit while in review #4139
1f1a79e
@pdurbin
permit metadata updates by curators via SWORD #4139
e5df2a8
@pdurbin
assert authors (!) and curators can edit metadata in review #4139 #3777
445e1ed 
Authors should not be able to edit metadata while in review. The GUI
disallows this as of Dataverse 4.8 but it was not fully implemented
because authors can make edits via the native API.

Also add a sample JSON file for making edits for progress toward
closing #3777 some day.
@pdurbin
enable Edit button if you can publish #4139
830fd97
@pdurbin
in commands, prevent author from editing while in review #4139
013d648
@pdurbin
consolidate business logic #4139
b2cf086
@pdurbin pdurbin mentioned this pull request Oct 16, 2017
Closed
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b2cf086 on 4139-curator-edits-in-review into ** on develop**.

@pdurbin pdurbin mentioned this pull request Oct 16, 2017
Closed
@pdurbin
reuse checkInReviewEditLock method (check for locks) #4139
360c249 
We want to make sure people who can legitimately edit datasets can still
do so.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 360c249 on 4139-curator-edits-in-review into ** on develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 31043c4 on 4139-curator-edits-in-review into ** on develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 78538eb on 4139-curator-edits-in-review into ** on develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 52c78db on 4139-curator-edits-in-review into ** on develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1920f1f on 4139-curator-edits-in-review into ** on develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 272b9bf on 4139-curator-edits-in-review into ** on develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 14253e2 on 4139-curator-edits-in-review into ** on develop**.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 12.429% when pulling 4a4e803 on 4139-curator-edits-in-review into 4e75b2b on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 12.429% when pulling f893a75 on 4139-curator-edits-in-review into 4e75b2b on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 12.428% when pulling b754d9e on 4139-curator-edits-in-review into 4e75b2b on develop.

@pdurbin
Copy link
Member Author

pdurbin commented Oct 18, 2017

Closing in favor of pull request #4216.

@pdurbin pdurbin closed this Oct 18, 2017
@pdurbin pdurbin mentioned this pull request Oct 18, 2017
Closed
@poikilotherm poikilotherm deleted the 4139-curator-edits-in-review branch July 1, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdurbin @coveralls @sekmiller