Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow steps don't roll back cleanly #4124

Closed
pameyer opened this issue Sep 6, 2017 · 3 comments
Closed

workflow steps don't roll back cleanly #4124

pameyer opened this issue Sep 6, 2017 · 3 comments
Assignees
@kcondon
Milestone
4.8.2 - Docker Im...

Comments

@pameyer
Copy link
Contributor

pameyer commented Sep 6, 2017

splitting off from #3561 :

More investigation:

  • create external workflow with http/sr stepType for pre-publish
  • create dataset
  • submit for review
  • turn off the system listening at the url for the http/sr step.
  • admin user published dataset (through UI)
  • server log shows workflow engine rolling back workflow; dataset page shows (new) message about publication workflow in progress, de-activated publish button, no return to author button.

Same behavior seen for publishing without a submit for review step; also seen with publishing through API.
@pameyer pameyer mentioned this issue Sep 6, 2017
Closed
@michbarsinai michbarsinai mentioned this issue Sep 26, 2017
Closed
5 tasks
@michbarsinai michbarsinai removed their assignment Sep 26, 2017
@scolapasta scolapasta self-assigned this Sep 26, 2017
@pdurbin pdurbin self-assigned this Oct 18, 2017
pdurbin added a commit that referenced this issue Oct 18, 2017
@pdurbin
Merge branch '4139-curator-edits-in-review' into 4124-4139-locks #4124 …
5aa1e23 
…#4139

Fixed bug in ReturnDatasetToAuthorCommand to properly remove the
InReview lock.

Conflicts:
src/main/java/edu/harvard/iq/dataverse/DatasetPage.java
src/main/java/edu/harvard/iq/dataverse/api/datadeposit/SwordUtil.java
pdurbin added a commit that referenced this issue Oct 18, 2017
@pdurbin
Merge branch '4139-curator-edits-in-review' into 4124-4139-locks #4124 …
ba64c54 
…#4139
pdurbin added a commit that referenced this issue Oct 18, 2017
@pdurbin
get ReturnDatasetToAuthorCommandTest passing #4124 #4139
5a53fa0 
The relationship between locks and users is confusing. I left a TODO.
This was referenced Oct 18, 2017
Merged
Closed
@pdurbin
Copy link
Member

pdurbin commented Oct 18, 2017

As discussed in standup, there are merged conflicts between branch 4124-workflow-clean-rollback (pull request #4165) and branch 4139-curator-edits-in-review (pull request #4208) and I have just resolved conflicts between the two branches and created a new branch called 4124-4139-locks that is now pull request #4216. Both #4124 and #4139 will be tested against this new pull request. I'll close the old pull requests. There was a bug in pull request #4165 where the lock was not being removed when a dataset was returned to the author but this is fixed in the new pull request.

@sekmiller and I plan to poke around at the new branch a bit and then move both issues to QA.

@kcondon mentioned that a test environment is required to test this issue. I'm unclear how to test this issue myself so if anyone knows, please leave a comment. I'm not sure if the first comment/description of this issue lays out the steps or not. It says "more investigation".

pdurbin added a commit that referenced this issue Oct 18, 2017
@pdurbin
add disabled test for ConcurrentModificationException #4124 #4139
fa3bc31
@pdurbin
Copy link
Member

pdurbin commented Oct 18, 2017

@sekmiller and I believe we're done messing with the code in pull request #4216 so I'm moving this to Code Review at https://waffle.io/IQSS/dataverse

@pdurbin pdurbin removed their assignment Oct 18, 2017
pdurbin added a commit that referenced this issue Oct 19, 2017
@pdurbin
Merge branch 'develop' into 4124-4139-locks #4124 #4139
cf9d208
@djbrooke djbrooke added this to the 4.8.2 - Updated Dataset Locking milestone Oct 19, 2017
pdurbin added a commit that referenced this issue Oct 20, 2017
@pdurbin
Merge branch 'develop' into 4124-4139-locks #4124 #4139
8457b92
matthew-a-dunlap added a commit that referenced this issue Oct 23, 2017
@matthew-a-dunlap
Import fix and comment change #4124 #4139
4de7fcf
@kcondon kcondon self-assigned this Oct 24, 2017
@kcondon
Copy link
Contributor

kcondon commented Nov 2, 2017

This works, tested against RSAL mock.

@kcondon kcondon closed this as completed Nov 3, 2017
@kcondon kcondon removed the Status: QA label Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.8.2 - Docker Images, Dataset Lockin...
Development

No branches or pull requests
8 participants
@pdurbin @landreev @michbarsinai @scolapasta @kcondon @djbrooke @matthew-a-dunlap @pameyer