Skip to content

fix: fix bug in generateNewIdentifierByStoredProcedure#12127

Open
vera wants to merge 3 commits intoIQSS:developfrom
vera:fix/12126
Open

fix: fix bug in generateNewIdentifierByStoredProcedure#12127
vera wants to merge 3 commits intoIQSS:developfrom
vera:fix/12126

Conversation

@vera
Copy link
Contributor

@vera vera commented Jan 29, 2026

What this PR does / why we need it:

This fixes a bug which prevents PIDs being generated using the db function generateIdentifierFromStoredProcedure. For more details see the issue below.

Which issue(s) this PR closes:

Special notes for your reviewer:

/

Suggestions on how to test this:

  • Start Dataverse configured with a default PID provider with identifier-generation-style=storedProcGenerated, e.g.
        -Ddataverse.pid.testpid.type=perma
        -Ddataverse.pid.testpid.label=PermalinkProvider
        -Ddataverse.pid.testpid.authority=test
        -Ddataverse.pid.testpid.shoulder=
        -Ddataverse.pid.testpid.permalink.base-url=https://example.com/
        -Ddataverse.pid.testpid.permalink.separator=-
        -Ddataverse.pid.testpid.identifier-generation-style=storedProcGenerated

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

/

Is there a release notes update needed for this change?:

Not sure

Additional documentation:

/

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the analogous change we made to the download estimation query, so I'll approve it. @vera - thanks for the quick fix - can you add a release note so we make sure that people know this is fixed (in 6.10 at least).

@github-project-automation github-project-automation bot moved this to Ready for QA ⏩ in IQSS Dataverse Project Jan 29, 2026
@qqmyers qqmyers moved this from Ready for QA ⏩ to Ready for Triage in IQSS Dataverse Project Jan 29, 2026
@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Jan 29, 2026
@qqmyers qqmyers added this to the 6.10 milestone Jan 29, 2026
@vera
Copy link
Contributor Author

vera commented Jan 30, 2026

can you add a release note so we make sure that people know this is fixed (in 6.10 at least).

Done!

@scolapasta scolapasta moved this from Ready for Triage to Ready for QA ⏩ in IQSS Dataverse Project Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: 3 A percentage of a sprint. 2.1 hours.

Projects

Status: Ready for QA ⏩

Development

Successfully merging this pull request may close these issues.

ERROR: procedure generateidentifierfromstoredprocedure(unknown) does not exist

2 participants