ERROR: procedure generateidentifierfromstoredprocedure(unknown) does not exist

[vera]

First of all, I'm not sure if this is really a bug or a misconfiguration on my side.

I am trying to update our fork from Dataverse v6.8 to v6.9.

I have configured one of my PID providers to use "storedProcGenerated" and have created a custom generateIdentifierFromStoredProcedure function in the db. This setup was working fine using Dataverse v6.8.

Now, when I try to create a dataset using that PID provider, it fails with the following error:

Internal Exception: org.postgresql.util.PSQLException: ERROR: procedure generateidentifierfromstoredprocedure(unknown) does not exist
  Hint: No procedure matches the given name and argument types. You might need to add explicit type casts.
  Position: 6
Error Code: 0
Call: CALL generateIdentifierFromStoredProcedure(?)
        bind => [1 parameter bound]
Query: ResultSetMappingQuery(name="Dataset.generateIdentifierFromStoredProcedure" )

After searching the issues, I found this similar bug report: #11980 which seems to have been fixed by making the code changes here:

https://github.com/IQSS/dataverse/pull/11827/changes

Now I'm wondering whether similar changes should have been made to the code which calls generateIdentifierFromStoredProcedure here and here:

• https://github.com/IQSS/dataverse/blob/v6.9/src/main/java/edu/harvard/iq/dataverse/Dataset.java#L109-L115
• https://github.com/IQSS/dataverse/blob/v6.9/src/main/java/edu/harvard/iq/dataverse/DvObjectServiceBean.java#L405

...or, like I said, whether it's an issue on my side. Thanks in advance for taking a look at this :)

[qqmyers]

I think what you're saying makes sense. FWIW: my guess was that the problems relate to Payara updating the version of EclipseLink they use. I don't think there are automated tests for the identifier from stored procedure call, contributing to it being missed.

[vera]

I see. Yes, I saw that there's an integration test, but I think it's outdated and has been disabled.

I'm just testing whether implementing a fix as I suggested above works, if it does, I'll go ahead and open a PR.