-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
displayOnCreate set to true for depositor and dateOfDeposit in Citation metadata block #10884
displayOnCreate set to true for depositor and dateOfDeposit in Citation metadata block #10884
Conversation
…layOnCreate fields
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GPortas looks good - just a quick question (that shouldn't block this moving forward), in the SPA, are you pre populating the fields (as in the JSF) with the user / current date? If not, should that be a new issue?
@scolapasta Currently we are not pre populating them, since we needed this API change to make these fields appear in the dataset creation form. Our plan was to work on it once this API extension was ready. I have created an issue for it: IQSS/dataverse-frontend#510 |
What this PR does / why we need it:
The fields depositor and dateOfDeposit in the citation.tsv metadatablock have been updated to have the property
displayOnCreate
set toTRUE
.Which issue(s) this PR closes:
Closes #10850
Suggestions on how to test this:
onlyDisplayedOnCreate=true
:curl "$SERVER_URL/api/metadatablocks?returnDatasetFieldTypes=true&onlyDisplayedOnCreate=true"
Verify that within the
citation
metadata block, depositor and dateOfDeposit are now retrieved.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
Yes, attached.
Special notes:
When using the generated docker image from this PR in the SPA, the fields depositor and dateOfDeposit are displayed on dataset creation, as in JSF: