Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citation.tsv: set displayOnCreate=TRUE for depositor and dateOfDeposit #10850

Closed
ekraffmiller opened this issue Sep 17, 2024 · 0 comments · Fixed by #10884
Closed

Citation.tsv: set displayOnCreate=TRUE for depositor and dateOfDeposit #10850

ekraffmiller opened this issue Sep 17, 2024 · 0 comments · Fixed by #10884
Assignees
Labels
FY25 Sprint 6 FY25 Sprint 6 FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q3 Not related to any specific Q3 feature SPA These changes are required for the Dataverse SPA
Milestone

Comments

@ekraffmiller
Copy link
Contributor

This code change is needed to have the metadata fields in the SPA Create Dataset form match what is in the JSF form.

In the JSF Create Dataset form, metadata fields are displayed if displayOnCreate = TRUE, or if the metadata field has been prefilled with a value. Metadata fields are preset if either with user information or a default value defined in the dataset template (if it exists). The backing bean for the Create Dataset form prefills depositor with the current user, and dateOfDeposit with the current date.

In the SPA, metadata fields are only displayed if displayOnCreate = TRUE. The logic for getting default values from a dataset template hasn't been implemented yet. The prefills for displayed fields are set in the UI, not from the API.

So to match the SPA with the JSF, we need to update depositor and dateOfDeposit with create=TRUE.

@ekraffmiller ekraffmiller added SPA These changes are required for the Dataverse SPA GREI Re-arch Issues related to the GREI Dataverse rearchitecture labels Sep 17, 2024
@GPortas GPortas added the Size: 3 A percentage of a sprint. 2.1 hours. label Sep 17, 2024
@GPortas GPortas moved this to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Sep 18, 2024
@GPortas GPortas added FY25 Sprint 6 FY25 Sprint 6 SPA.Q3 Not related to any specific Q3 feature labels Sep 18, 2024
@GPortas GPortas self-assigned this Sep 24, 2024
@cmbz cmbz added the FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) label Sep 25, 2024
GPortas added a commit that referenced this issue Sep 26, 2024
stevenwinship pushed a commit that referenced this issue Sep 27, 2024
…on metadata block (#10884)

* Changed: displayOnCreate set to true for depositor and dateOfDeposit in citation.tsv

* Changed: MetadataBlocksIT test assertion for new total number of displayOnCreate fields

* Added: release notes for #10850

* Added: minor tweak to release notes
@pdurbin pdurbin added this to the 6.4 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 6 FY25 Sprint 6 FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q3 Not related to any specific Q3 feature SPA These changes are required for the Dataverse SPA
Projects
None yet
4 participants