Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return to Author: When returning datasets that were submitted for review, I want to add a feedback note. #3702

Closed
amberleahey opened this issue Mar 16, 2017 · 9 comments · Fixed by #10137
Closed

Return to Author: When returning datasets that were submitted for review, I want to add a feedback note. #3702

amberleahey opened this issue Mar 16, 2017 · 9 comments · Fixed by #10137
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: In Review Workflow Feature: Notifications Type: Feature a feature request User Role: Curator Curates and reviews datasets, manages permissions UX & UI: Design This issue needs input on the design of the UI and from the product owner UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF
Milestone
6.2

Comments

@amberleahey
Copy link

Queen's University Library is investigating their institutional Dataverse setup (hosted with SP Dataverse), to improve the feedback mechanism for datasets that are submitted for review and publishing to the Queen's University Dataverse https://dataverse.scholarsportal.info/dataverse/queens .

Requested improvement for providing feedback to authors / contributors when submitting datasets:

When clicking on the “Return to Author” there is no option to add an explanatory note to the email that the user receives. Is it possible to change this? It would be more efficient if a reviewer could add a note to the email Dataverse is sending outlining why the dataset has been sent back instead of having to send a another separate email.
@pdurbin pdurbin mentioned this issue Mar 17, 2017
Closed
@pdurbin
Copy link
Member

pdurbin commented Mar 17, 2017

@amberleahey thanks for opening this issue. There's a related issue at #3172 and probably others that have to do with the "Submit For Review" workflow. I just added a new label called "Component: In Review Workflow" but we can rename this label to whatever makes the most sense to group these related issues together.

@pameyer pameyer mentioned this issue Jun 21, 2017
Closed
@pdurbin
Copy link
Member

pdurbin commented Jun 23, 2017

@amberleahey please keep an eye on #3943 in which we're planning on building the backend to support this feature.

This was referenced Jun 25, 2017
Closed
Closed
@pdurbin
Copy link
Member

pdurbin commented Jun 26, 2017

#1684 is also related.

@dlmurphy dlmurphy added the UX & UI: Design This issue needs input on the design of the UI and from the product owner label Jun 29, 2017
@pdurbin pdurbin added User Role: Curator Curates and reviews datasets, manages permissions User Role: Depositor Creates datasets, uploads data, etc. labels Jul 4, 2017
@kcondon kcondon mentioned this issue Sep 15, 2017
Closed
@pameyer pameyer added Persona: Curator and removed Feature: In Review Workflow UX & UI: Design This issue needs input on the design of the UI and from the product owner User Role: Curator Curates and reviews datasets, manages permissions User Role: Depositor Creates datasets, uploads data, etc. labels Nov 7, 2017
@pdurbin pdurbin added Feature: In Review Workflow UX & UI: Design This issue needs input on the design of the UI and from the product owner and removed Component: In Review Workflow labels Nov 13, 2017
@dlmurphy dlmurphy changed the title Submit for review / Return to author - add explanatory note field Return to Author - When returning datasets that were submitted for review, I want to add a feedback note. Jan 11, 2018
@pdurbin pdurbin added the Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. label Oct 14, 2022
@pdurbin pdurbin added Type: Feature a feature request UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF User Role: Curator Curates and reviews datasets, manages permissions labels Oct 7, 2023
@DS-INRAE DS-INRAE mentioned this issue Oct 17, 2023
Open
luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Nov 22, 2023
@luddaniel
IQSS#3702 - Returning to author now requires a commented reason that …
a4c9d28 
…is sent by email to the author
luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Nov 22, 2023
@luddaniel
IQSS#3702 - Returning to author now requires a commented reason that …
d527fc8 
…is sent by email to the author
@luddaniel luddaniel mentioned this issue Nov 22, 2023
Merged
@pdurbin
Copy link
Member

pdurbin commented Nov 28, 2023

@amberleahey @kmika11 check out the video in this new pull request by @luddaniel:

@DS-INRAE DS-INRAE mentioned this issue Nov 29, 2023
Open
luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Nov 29, 2023
@luddaniel
IQSS#3702 - Increased maxlength of message to 2000 + Added email cont…
36a259f 
…acts of collection in return to author email
luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Nov 29, 2023
@luddaniel
IQSS#3702 - Added test on null or empty comment for ReturnDatasetToAu…
136d42b 
…thorCommand
luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Nov 29, 2023
@luddaniel
IQSS#3702 fixed Unit Tests errors
1112ae7
luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Dec 13, 2023
@luddaniel
IQSS#3702 - Code commentary to be removed
7d5e940
luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Jan 17, 2024
@luddaniel
IQSS#3702 - Adding release note
ba8c58d
luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Jan 17, 2024
@luddaniel
IQSS#3702 - Adding last Bundle.properties corrections
3c5f989
@philippconzett
Copy link
Contributor

Sorry for joining this conversation late. I wasn't aware of this feature request.

In the related PR, @pdurbin commented that his "only reservation is that it's a new required field".

In DataverseNO, after returning a dataset, we send an email to the depositor attaching a curation report with feedback and suggestions/instructions on what to address to make the dataset in line with our deposit guidelines.

So, I wonder whether it will be possible to turn off the feature suggested in this GitHub issue?

luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Feb 28, 2024
@luddaniel
IQSS#3702 - Updated release note and guide
2efa607
stevenwinship pushed a commit that referenced this issue Mar 6, 2024
@luddaniel @pdurbin
Returning to author now requires a reason that is sent by email to th…
4716c7a 
…e author (#10137)

* #3702 - Returning to author now requires a commented reason that is sent by email to the author

* Update src/main/java/propertyFiles/Bundle.properties

Co-authored-by: Philip Durbin <philipdurbin@gmail.com>

* #3702 - Increased maxlength of message to 2000 + Added email contacts of collection in return to author email

* #3702 - Added test on null or empty comment for ReturnDatasetToAuthorCommand

* #3702 fixed Unit Tests errors

* #3702 - Code commentary to be removed

* #3702 - Adding release note

* #3702 - Adding last Bundle.properties corrections

* #3702 - Updated release note and guide

---------

Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
@pdurbin pdurbin added this to the 6.2 milestone Mar 6, 2024
@cmbz cmbz mentioned this issue Apr 1, 2024
Open
@DS-INRAE DS-INRAE moved this to Done in Recherche Data Gouv Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: In Review Workflow Feature: Notifications Type: Feature a feature request User Role: Curator Curates and reviews datasets, manages permissions UX & UI: Design This issue needs input on the design of the UI and from the product owner UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF
Projects
Recherche Data Gouv
Status: Done
Milestone
6.2
8 participants
@pdurbin @djbrooke @pameyer @amberleahey @jggautier @philippconzett @dlmurphy @kmika11