-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Download w/ Rsync UI/Workflow changes #3998
Comments
UI IMPACT As defined in the following mockup document. Dataverse
Dataset (view/no files)
Dataset (view/has file/success-upload)
Edit Dataset Terms
File
User Guide
|
From another round of testing:
|
Wrote some new messaging for the rsync download pages, would love to get @pameyer's verification that everything is accurate. Here are some earlier mockups, followed by the revised instructional text. Data Access tab at the bottom of the file page:
Gray instructions at top: "This data can be accessed through your computer's Terminal using the commands below. For more information, see our User Guide." ("User Guide" links to a guide page with more info) Local Access tooltip: "If this data is locally available, this is its file path." Download Access tooltip: "Download this data by running this command from your preferred mirror." Verify Data tooltip: "This command runs a checksum to verify the integrity of the data you've downloaded." File table at the bottom of the dataset page:
Text stylingAll red-on-pink text should be changed to highlighted black text, as in this earlier mockup: |
@dlmurphy looks good to me |
One update - these UI changes should be conditional on the downloadMethods setting that was previously added (for this purpose). |
First draft of the rsync download section.
It doesn't say so in the checklist explicitly, but, there is no "Download" button on the page for a package file, correct? (just to confirm). I.e., that "Data Access" text on the dataset page, in the mockup above, replaces the current Download button - correct? If so, the checklist really should say "render logic to hide download count AND download button"... |
It sounds so far like this issue is mostly about changing the rendering of the dataset and other pages for "package" files. (and, it sounds like, you don't need this Datafile to contain an actual physical package directory on the filesystem; at least not for the purposes of working on the page...) |
@landreev - you are correct; there shouldn't be a "Download" button |
…er logic to only display it on dataset pg when dataset is unpublished. [ref #3998]
Clarified phrasing of upload files instructions to be more clear and match the upload script.
I may have been able to fix that annoying "CSS blink after the page auto-refreshes" issue. (the "blink" itself was a Chrome-only issue; but the auto-refresh was also causing the files table to be resized incorrectly, and that was affecting all (or most) browsers. I've updated the checklist entry). It was all caused by the "update=@ALL" in the autorefresh block. It's just that for whatever reason I couldn't get it to properly refresh all the affected page parts without resorting to "all", back when I was working on it for tabular ingest. (so, this was not anything introduced in these rsync branches; we've had this issue forever). But, as I said, I think I got it to work, by updating just the affected components (the files table; the citation; the edit/publish/etc. buttons; and the message panel). But please re-test carefully. And see if I missed anything. |
Remove 'duplicated' in-review notification Set workflow complete notification to notify for correct roles Moved role-adding notification to happen after publish success/notification Minor refactoring.
Wait, my commit with the message fix didn't seem to go through. Trying again. |
@kcondon I've added a similar success message to file delete on the single file page as well. |
Download compliment to #3348 .
Backend dependency on #3561
The text was updated successfully, but these errors were encountered: