-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/406 add edit dataset metadata form #422
Merged
ekraffmiller
merged 51 commits into
develop
from
feat/406-add-edit-dataset-metadata-form
Jul 15, 2024
Merged
Feat/406 add edit dataset metadata form #422
ekraffmiller
merged 51 commits into
develop
from
feat/406-add-edit-dataset-metadata-form
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aset-metadata-form
g-saracca
added
UI
Tasks related to the user interface (UI) or frontend development
integration
Tasks involving the connection and interaction of UI features with the Dataverse API
SPA: Edit Dataset Page
GREI Re-arch
GREI re-architecture-related
Size: 3
A percentage of a sprint. 2.1 hours.
Waiting
labels
Jun 26, 2024
ekraffmiller
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just one issue with bounding box validation, which will be tracked in a separate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
GREI Re-arch
GREI re-architecture-related
integration
Tasks involving the connection and interaction of UI features with the Dataverse API
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: Edit Dataset Page
UI
Tasks related to the user interface (UI) or frontend development
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the Edit Dataset Metadata section/page.
A reusable form component is created for the creation of a dataset, as well as for editing the metadata of a dataset.
Which issue(s) this PR closes:
Closes #406
Special notes for your reviewer:
Some external issues were encountered during the development of this feature:
I have added extra functionalities such as:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the Create Dataset Form
Step 3: Test the Edit Dataset Metadata section
You then can clear any of the sibling fields that was filled and you will notice that the Name field is no longer required.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: