-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/420 Select Advanced (single and multiple selection with search) #424
Conversation
Hi @GermanSaracca, it looks good! I just wanted to check the behavior of the Single Select - it doesn't close the dropdown when an option is selected. Is that expected behavior? Screen.Recording.2024-07-17.at.4.51.20.PM.mov |
Hi @ekraffmiller, yes that is the expected behaviour, thanks! |
@ekraffmiller I correct myself, you are right, in single selection the options menu should close when choosing an option. Many thanks! |
@ekraffmiller change applied 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, approved!
@GermanSaracca Can you please resolve merge conflicts? Thanks! |
@GPortas conflicts solved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great in all modes
What this PR does / why we need it:
Adds a new Select component to the design system and integrates it into the EditDatasetMetadata form for multiple controlled vocabularies and for non-multiple controlled vocabularies when they have more than 10 options.
Removes
SelectMultiple
component, thisSelectAdvanced
component behaves as single or multiple selection.Which issue(s) this PR closes:
Closes #420
Special notes for your reviewer:
Suggestions on how to test this:
npm i
.cd packages/design-system && npm run build
.npm run storybook
SelectAdvanced
component in single selection mode.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
SelectAdvanced on single mode with search.
SelectAdvanced on single mode without search.
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A