-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/273 deaccessioned dataset unauthenticated #367
Fix/273 deaccessioned dataset unauthenticated #367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, looks great to me. I have already tested the behavior in the JSF version and tested the behavior in this branch and everything works as expected.
The error was occurring because Promise.all failed due to the api call to downloadSizes when canEditDataset was false right?
Attached is a screenshot of how a non-authenticated user can view a deaccesioned dataset.
Yes, that's right, the unauthenticated user doesn't have permission to get the downloadSizes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Deaccessioned page it's working well with an unauthenticated user
…nauthenticated Fix/273 deaccessioned dataset unauthenticated
What this PR does / why we need it:
This PR fixes an issue where the Dataset page of a deaccessioned dataset is not viewable for unauthenticated users.
To recreate this error, create dataset, publish it, then deaccession it. In JSF, when you log out, the deaccessioned dataset is still viewable to the unauthenticated user. If you go to the SPA and try to view the dataset, you get 'Page Not Found'
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Follow the steps to reproduce above. Test that the Dataset page is still viewable when the user is logged out.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: