Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx dataset loading logic for Deaccessioned Dataset #273

Closed
ekraffmiller opened this issue Jan 4, 2024 · 3 comments · Fixed by #367
Closed

FIx dataset loading logic for Deaccessioned Dataset #273

ekraffmiller opened this issue Jan 4, 2024 · 3 comments · Fixed by #367
Assignees
Labels
bug Something isn't working pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. UI Tasks related to the user interface (UI) or frontend development

Comments

@ekraffmiller
Copy link
Contributor

When a dataset is deaccessioned, it still should be visible to unauthenticated users, but only the citation and deaccession reason are viewable.
For example in JSF:
Screenshot 2024-01-04 at 1 45 21 PM

There is a bug in the SPA where getDatasetFilesTotalDownloadSize() is called for a deaccessioned dataset and an unauthenticated user. This API call returns an error because the user doesn't have permission to view the download sizes for a deaccessioned dataset. Because of this error, the SPA redirects to a published version of the dataset.
Screenshot 2024-01-04 at 1 52 17 PM

We need to update the logic of the SPA so that getDatasetFilesTotalDownloadSize() and other file related API's are only called if the user has permission to view the files. For example, if the dataset is deaccessioned, but the user has edit permissions on the dataset.

@ekraffmiller ekraffmiller added bug Something isn't working pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows UI Tasks related to the user interface (UI) or frontend development labels Jan 4, 2024
@MellyGray MellyGray added the Size: 10 A percentage of a sprint. 7 hours. label Jan 17, 2024
@GPortas GPortas moved this to SPRINT READY in IQSS Dataverse Project Jan 17, 2024
@GPortas GPortas moved this from SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Jan 17, 2024
@MellyGray MellyGray moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Jan 26, 2024
@MellyGray MellyGray self-assigned this Jan 26, 2024
@MellyGray
Copy link
Contributor

MellyGray commented Jan 29, 2024

@ekraffmiller I attempted to replicate the issue and encountered an error with the 'get dataset deaccessioned' endpoint when the user is not authenticated. Therefore, I'm assuming you discovered this bug using a different image of Dataverse where the initial issue is resolved.

I tried running another image using ./run-env.sh 10207-bug-api-datasets-versions-latest-fix, but the 'get dataset deaccessioned' endpoint still fails when the user is unauthenticated.

I believe we need to first merge the above PR, as it currently seems impossible to open a deaccessioned dataset in the frontend if the user is unauthenticated.

Also, could you provide some steps on how to reproduce the bug regarding the 'getDatasetFilesTotalDownloadSize'?

I'm going to add the Waiting tag for the moment

@MellyGray MellyGray moved this from In Progress 💻 to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Jan 29, 2024
@MellyGray MellyGray removed their assignment Jan 29, 2024
@GPortas
Copy link
Contributor

GPortas commented Jan 31, 2024

Deprioritized and moved back to the SPA backlog.

This issue is not as important as others for the Beta Release and also requires further discussion.

@cmbz

@GPortas GPortas removed the Waiting label Mar 14, 2024
@GPortas GPortas moved this to SPRINT READY in IQSS Dataverse Project Mar 14, 2024
@GPortas GPortas moved this from SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Mar 27, 2024
@ekraffmiller ekraffmiller self-assigned this Apr 5, 2024
@ekraffmiller ekraffmiller moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Apr 5, 2024
@ekraffmiller ekraffmiller added Size: 3 A percentage of a sprint. 2.1 hours. and removed Size: 10 A percentage of a sprint. 7 hours. labels Apr 10, 2024
@ekraffmiller
Copy link
Contributor Author

@MellyGray I created a PR with steps to reproduce, I hope that makes sense, let me know if you have any questions or problems reproducing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. UI Tasks related to the user interface (UI) or frontend development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants