Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

178 publish collection use case #182

Merged
merged 9 commits into from
Sep 10, 2024
Merged

178 publish collection use case #182

merged 9 commits into from
Sep 10, 2024

Conversation

ekraffmiller
Copy link
Contributor

What this PR does / why we need it:

Creates a use case for publishing a collection

Which issue(s) this PR closes:

Related Dataverse PRs:

  • Depends on #

Special notes for your reviewer:

Suggestions on how to test this:

Inspect code and run tests.

Is there a release notes update needed for this change?:

Additional documentation:

g-saracca
g-saracca previously approved these changes Sep 3, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Approving!
If you can also @GPortas make a quick code review while doing the QA will be great, thanks!

@g-saracca g-saracca removed their assignment Sep 3, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! only one minor change related to a method doc. @ekraffmiller

}

/**
* Publishes a collection, given its identifier and the type of version update type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last part "and the type of version update type." should be removed!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GPortas thanks for finding that, done!

fix  Publish Collection use case documentation
@g-saracca
Copy link
Contributor

@ekraffmiller please merge develop into this branch before merging so we don't lose latest changes in file upload use case
cc: @GPortas

@GPortas GPortas merged commit 42c1ce3 into develop Sep 10, 2024
5 checks passed
@GPortas GPortas deleted the 178-publish-collection branch September 10, 2024 10:12
@GPortas GPortas added SPA.Q3.6 Publish Collection Original size: 3 labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 4 FY25 Sprint 4 FY25 Sprint 5 FY25 sprint 5 GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page SPA.Q3.6 Publish Collection
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Create use case for publishing a Collection
4 participants