Proposal to fix issue with annotations by adding a test in substituteAnnotation #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith an or instead of an and. Now the test is failing, proof that the assertion is checked :)
… a local variable in the same block or by a field (or a variable in another block). First detection implemented but patch not satisfying.
…sing autoimport
…rus/spoon into martin" This reverts commit 2609284, reversing changes made to 49d6e68.
…operties. Some choices have been done concerning some set methods in order to pass the test we should discuss.
Fix conflicts by solving imports.
… set to true or when it is set to false. When set to false, the scanner will detect name conflict and automatically import necessary types.
Solve conflict.
…g on CtElement (default behaviour until now).
… of getReferences
Solve in using version of inria/master
…ion is already available before adding it.
|
And dropwizard is well building with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #970 by adding a test in substituteAnnotation in ParentExiter: instead of just adding the annotation to the returnType of the method, it test before is the annotation is already there or not.