We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The API contract which should be enforced by the APITest.testSetterInNodes() IS NOT CHECKED, because this test is actually doing NOTHING.
Put the breakpoint on line 359
assertTrue("Check the method " + statement.getParent(CtMethod.class).getSignature() ...
and you will see it NEVER enters the loop.
I have made a PR #968, which fixes that bug....
Yes Travis reports the errors, but it is not bug in the PR #968, it is report about broken API contracts!
I am not going to fix PR #968, because I have no idea how to do it. But I guess it is good idea to fix it to avoid merging more and more invalid APIs.
The text was updated successfully, but these errors were encountered:
I am not going to fix PR #968, because I have no idea how to do it.
OK we'll look at it. Closing #968. Don't hesitate to reopen it before if you have a fix idea.
Sorry, something went wrong.
fix: test: APITest.testSetterInNodes() was not testing anything (#1022)…
23cffe1
…. fix #972.
Successfully merging a pull request may close this issue.
The API contract which should be enforced by the APITest.testSetterInNodes() IS NOT CHECKED, because this test is actually doing NOTHING.
Put the breakpoint on line 359
and you will see it NEVER enters the loop.
I have made a PR #968, which fixes that bug....
Yes Travis reports the errors, but it is not bug in the PR #968, it is report about broken API contracts!
I am not going to fix PR #968, because I have no idea how to do it. But I guess it is good idea to fix it to avoid merging more and more invalid APIs.
The text was updated successfully, but these errors were encountered: