Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test APITest.testSetterInNodes() does not work at all #972

Closed
pvojtechovsky opened this issue Nov 14, 2016 · 1 comment · Fixed by #1022
Closed

test APITest.testSetterInNodes() does not work at all #972

pvojtechovsky opened this issue Nov 14, 2016 · 1 comment · Fixed by #1022

Comments

@pvojtechovsky
Copy link
Collaborator

The API contract which should be enforced by the APITest.testSetterInNodes() IS NOT CHECKED, because this test is actually doing NOTHING.

Put the breakpoint on line 359

assertTrue("Check the method " + statement.getParent(CtMethod.class).getSignature() ...

and you will see it NEVER enters the loop.

I have made a PR #968, which fixes that bug....

Yes Travis reports the errors, but it is not bug in the PR #968, it is report about broken API contracts!

I am not going to fix PR #968, because I have no idea how to do it. But I guess it is good idea to fix it to avoid merging more and more invalid APIs.

@monperrus
Copy link
Collaborator

I am not going to fix PR #968, because I have no idea how to do it.

OK we'll look at it. Closing #968. Don't hesitate to reopen it before if you have a fix idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants