Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to the tech layer map used by klayout for DEF -> GDS #220

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

smunaut
Copy link

@smunaut smunaut commented Oct 14, 2024

No description provided.

@smunaut smunaut changed the base branch from main to dev October 14, 2024 14:04
With the current one, any 'PIN' (EDI) area would only end up
as 'pin' (datatype 2) in the GDS. But it also needs to appear
in the `drawing` (datatype 0).

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
@KrzysztofHerman
Copy link
Contributor

Thank you for this PR. I have tested is elaborating ricscv32i design using actual and proposed version of the map file. After streaming GDS and making XOR (using klayout) I found no difference. Could you please provide/reference some testcase where we could actually see the effects ?

@smunaut
Copy link
Author

smunaut commented Oct 17, 2024

See attached zip

pin_issue.zip

Note that to see the difference you need to change the "stipple" for the drawing layer because in the default klayout layer properties the difference is near invisible.

2024-10-17_1918x1178_scrot_002
2024-10-17_1918x1178_scrot

@smunaut
Copy link
Author

smunaut commented Oct 22, 2024

BTW I think the issue is not usually visible in ORFS because the pins created by default are the same width as the traces and might have their anchor point on the edge rather than in the center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants