-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liberty view for IO cells update. #104
Conversation
…n make it feasible to run ORFS flow Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has some indentation issues.
); | ||
} | ||
} | ||
}pin (pad) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}pin (pad) { | |
} | |
pin (pad) { |
); | ||
} | ||
} | ||
} } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} } | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See all following cells have the same issue.
} | ||
} } | ||
|
||
cell (sg13g2_IOPadIOVss) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move both IO cells at the beginning or move Vss/Vdd cells from the beginning here?
); | ||
} | ||
} | ||
}pin (c2p) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be next line.
); | ||
} | ||
} | ||
}pin (c2p) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be next line.
); | ||
} | ||
} | ||
}pin (c2p) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be next line.
); | ||
} | ||
} | ||
}pin (c2p) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be next line.
); | ||
} | ||
} | ||
}pin (c2p) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be next line.
); | ||
} | ||
} | ||
}pin (c2p) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be next line.
); | ||
} | ||
} | ||
timing () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any obvious issue here with these two timings. I wonder if timings are missing in the pin c2p and pin c2p_en definitions...
…EF. Dummy modules and cells added in Verilog and Liberty files Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
…ters added Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
There were some updates, which limit the cells to the list defined in
Also some properties of the filler cell were added together with a fix on positive/negative unate. I ran ORFS using these updated views and still got some issues that are listed below:
Maybe @stafverhaegen-chipflow could provide some solutions for |
Could it be missing pin definitions for power/ground? All IOPad cells have following pg_pins but not Corner/Filler cells.
|
@FatsieFS feel free to provide downgraded version of the LEF. As for |
…v_pmos Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
@KrzysztofHerman |
The updated view contains definition of all IO cells provided in the library hence it is feasible to use it in ORFS to design a pad ring.