Tagging Updates: Name #2322
Merged
Tagging Updates: Name #2322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarjandu
requested review from
DailyDreaming,
xbrianh and
jeffrey856
and removed request for
DailyDreaming
DailyDreaming
approved these changes
Aug 5, 2019
| @@ -13,6 +13,7 @@ if [[ -z $DSS_DEPLOYMENT_STAGE ]]; then | |||
| fi | |||
|
|
|||
| export daemon_name=$1 | |||
| export daemon_tag=$(echo $daemon_name | cut -d '-' -f2-) | |||
There was a problem hiding this comment.
Why do you edit the daemon name instead of just using daemon_name?
There was a problem hiding this comment.
its to strip out dss from the name to avoid dss-dss-operations-dev
xbrianh
approved these changes
Aug 5, 2019
infra/buckets/s3.tf
Outdated
| @@ -3,7 +3,7 @@ data "aws_caller_identity" "current" {} | |||
| locals { | |||
| common_tags = "${map( | |||
| "managedBy" , "terraform", | |||
| "Name" , "${var.DSS_INFRA_TAG_PROJECT}-${var.DSS_DEPLOYMENT_STAGE}-${var.DSS_INFRA_TAG_SERVICE}", | |||
| "Name" , "${var.DSS_INFRA_TAG_SERVICE}-cloudstorage", | |||
There was a problem hiding this comment.
Can we specify which cloud?, e.g. something like -s3-storage and -gs-storage
There was a problem hiding this comment.
added tagging to google + differentiation of cloud
chmreid
added a commit
that referenced
this pull request
Aug 15, 2019
* master: Assert we don't checkout to the main bucket (avoiding a sync error). (#2350) Revert "Fix 500 on delete nonexistent bundle (fixes #1918)" Fix 500 on delete nonexistent bundle (fixes #1918) Simplify release scripting (#2347) More informative release status (#2345) Dedicated Trufflehog CI/CD stage (#2342) Check the correct DCP branch status (#2339) Fix daemon import test CI (#2338) Terraform v0.12.6 compatibility updates (#2337) Limit a user's v2 subscriptions to 100 per replica. (#2310) Limit user v1 subscriptions to 100 per replica. (#2309) fixed integration test errors (#2326) Delete Test Subscription (#2304) Tagging Updates: Name (#2322)
chmreid
added a commit
that referenced
this pull request
Aug 15, 2019
* master: Schema typo fix (s/it/is) Assert we don't checkout to the main bucket (avoiding a sync error). (#2350) Revert "Fix 500 on delete nonexistent bundle (fixes #1918)" Fix 500 on delete nonexistent bundle (fixes #1918) Simplify release scripting (#2347) More informative release status (#2345) Dedicated Trufflehog CI/CD stage (#2342) Check the correct DCP branch status (#2339) Fix daemon import test CI (#2338) Terraform v0.12.6 compatibility updates (#2337) Limit a user's v2 subscriptions to 100 per replica. (#2310) Limit user v1 subscriptions to 100 per replica. (#2309) fixed integration test errors (#2326) Delete Test Subscription (#2304) Tagging Updates: Name (#2322)
chmreid
pushed a commit
that referenced
this pull request
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change resource tagging
Nameto reference sub-component of the DSSadds labels to gcp buckets