Skip to content

Limit a user's v2 subscriptions to 100 per replica. #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 9, 2019

Conversation

DailyDreaming
Copy link
Contributor

No description provided.

@DailyDreaming DailyDreaming changed the title Limit a user's v2 subscriptions to 10. Limit a user's v2 subscriptions to 100. Jul 31, 2019
@DailyDreaming DailyDreaming changed the title Limit a user's v2 subscriptions to 100. Limit a user's v2 subscriptions to 100 per replica. Jul 31, 2019
Copy link
Member

@xbrianh xbrianh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's investigate Select COUNT DynamoDB queries. That would be preferable to fetching subscription bodies just to count them.

Copy link
Contributor

@chmreid chmreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@xbrianh xbrianh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please see comment about including new errors codes in dss-api.yml.

@DailyDreaming DailyDreaming merged commit 5d1314a into master Aug 9, 2019
@DailyDreaming DailyDreaming deleted the lon-limit-v2-subscriptions branch August 9, 2019 22:56
chmreid added a commit that referenced this pull request Aug 15, 2019
…s-secrets-tests

* 'master' of github.com:HumanCellAtlas/data-store:
  Assert we don't checkout to the main bucket (avoiding a sync error). (#2350)
  Revert "Fix 500 on delete nonexistent bundle (fixes #1918)"
  Fix 500 on delete nonexistent bundle (fixes #1918)
  Simplify release scripting (#2347)
  More informative release status (#2345)
  Dedicated Trufflehog CI/CD stage (#2342)
  Check the correct DCP branch status (#2339)
  Fix daemon import test CI (#2338)
  Terraform v0.12.6 compatibility updates (#2337)
  Limit a user's v2 subscriptions to 100 per replica. (#2310)
  Limit user v1 subscriptions to 100 per replica. (#2309)
chmreid added a commit that referenced this pull request Aug 15, 2019
* master:
  Assert we don't checkout to the main bucket (avoiding a sync error). (#2350)
  Revert "Fix 500 on delete nonexistent bundle (fixes #1918)"
  Fix 500 on delete nonexistent bundle (fixes #1918)
  Simplify release scripting (#2347)
  More informative release status (#2345)
  Dedicated Trufflehog CI/CD stage (#2342)
  Check the correct DCP branch status (#2339)
  Fix daemon import test CI (#2338)
  Terraform v0.12.6 compatibility updates (#2337)
  Limit a user's v2 subscriptions to 100 per replica. (#2310)
  Limit user v1 subscriptions to 100 per replica. (#2309)
  fixed integration test errors (#2326)
  Delete Test Subscription (#2304)
  Tagging Updates: Name (#2322)
chmreid added a commit that referenced this pull request Aug 15, 2019
* master:
  Schema typo fix (s/it/is)
  Assert we don't checkout to the main bucket (avoiding a sync error). (#2350)
  Revert "Fix 500 on delete nonexistent bundle (fixes #1918)"
  Fix 500 on delete nonexistent bundle (fixes #1918)
  Simplify release scripting (#2347)
  More informative release status (#2345)
  Dedicated Trufflehog CI/CD stage (#2342)
  Check the correct DCP branch status (#2339)
  Fix daemon import test CI (#2338)
  Terraform v0.12.6 compatibility updates (#2337)
  Limit a user's v2 subscriptions to 100 per replica. (#2310)
  Limit user v1 subscriptions to 100 per replica. (#2309)
  fixed integration test errors (#2326)
  Delete Test Subscription (#2304)
  Tagging Updates: Name (#2322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants