Skip to content

Fix sentence splitting with mecab #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Heliozoa wants to merge 3 commits into from
Closed

Fix sentence splitting with mecab #43

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb992ae
Fix sentence splitting with mecab
Heliozoa Sep 28, 2022
d995a60
Handle more edge cases
Heliozoa Sep 28, 2022
69923d1
Handle nested quotes
Heliozoa Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions inc/database_connect.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ function update_japanese_word_count($japid) {

// STEP 1: write the useful info to a file
$db_to_mecab = tempnam(sys_get_temp_dir(), "{$tbpref}db_to_mecab");
$mecab_args = ' -F %m%t\\t -U %m%t\\t -E \\n ';
$mecab_args = ' -F %m%t\\t -U %m%t\\t -E ""';
$mecab = get_mecab_path($mecab_args);

$sql = "SELECT WoID, WoTextLC FROM {$tbpref}words
Expand Down Expand Up @@ -745,7 +745,7 @@ function parse_japanese_text($text, $id)

$file_name = tempnam(sys_get_temp_dir(), $tbpref . "tmpti");
// We use the format "word num num" for all nodes
$mecab_args = " -F %m\\t%t\\t%h\\n -U %m\\t%t\\t%h\\n -E EOS\\t3\\t7\\n";
$mecab_args = " -F %m\\t%t\\t%h\\n -U %m\\t%t\\t%h\\n -E ''";
$mecab_args .= " -o $file_name ";
$mecab = get_mecab_path($mecab_args);

Expand Down Expand Up @@ -773,17 +773,22 @@ function parse_japanese_text($text, $id)
$id>0 ?
"(SELECT ifnull(max(`SeID`)+1,1) FROM `{$tbpref}sentences`)"
: 1
) . ", @count:=0,@last_term_type:=0;"
) . ", @count:=0,@last_term_type:=0, @at_sentence_end:=false, @inside_quote:=0;"
);

$sql =
"LOAD DATA LOCAL INFILE " . convert_string_to_sqlsyntax($file_name) . "
INTO TABLE {$tbpref}temptextitems2
FIELDS TERMINATED BY '\\t'
LINES TERMINATED BY '" . PHP_EOL . "'
(@term, @node_type, @third)
SET
TiSeID = IF(@term_type=2 OR (@term='EOS' AND @third='7'), @sid:=@sid+1,@sid),
TiSeID = CASE
WHEN (@inside_quote = 0 AND @term IN ('「', '【', '『', '〝')) THEN @sid:=@sid+(@inside_quote := @inside_quote + 1)*(@at_sentence_end := false)
WHEN (@inside_quote > 0 AND @term IN ('】', '」', '』', '〟')) THEN @sid:=@sid+(@inside_quote := @inside_quote - 1)*(@at_sentence_end := false)
WHEN (@inside_quote = 0 AND @at_sentence_end = true AND (@node_type != 3 OR @term IN ('「', '」', '【', '】', '、', '，', '…', '‥', '『', '』', '〝', '〟', '：', '――'))) THEN @sid:=@sid+1+(@at_sentence_end := false)
WHEN (@inside_quote = 0 AND @node_type = 3 AND @term NOT IN ('「', '」', '【', '】', '、', '，', '…', '‥', '『', '』', '〝', '〟', '：', '――')) THEN @sid:=@sid*(@at_sentence_end := true)
ELSE @sid
END,
TiCount = (@count:= @count + CHAR_LENGTH(@term)) + 1 - CHAR_LENGTH(@term),
TiOrder = IF(
CASE
Expand Down