Update to JedWatson/react-select v1.0.0-rc.4 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate to prop-types and create-react-class packages
Added variables for shadow styles
Include a className of 'is-clearable' if clearable is true
* Fix #1394 * Updates following review * Updates following review by @JedWatson
* Fix selected option focus when valueKey is not "value" * Revert "Fix selected option focus when valueKey is not "value"" This reverts commit 45f5665e495a4d305743aef22bcc045bc374e1e1. * Fix on src/ instead of lib/
|
Might want to double check to make sure this issue isn't a bug JedWatson/react-select#1745 |
|
Confirmed, that bug is present (try the async example). 😞 I'll have to pull in some more recent commits. |
added 2 commits
May 23, 2017 12:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's pretty straightforward. Should just be bugfixes, including a patch for #72: https://github.com/JedWatson/react-select/blob/master/HISTORY.md#v100-rc4--2017-05-14