-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double click for expanding #72
Comments
I'm using react-select plus in my project. It requires double click for collapsing unlike the react-select. |
@alrms I've never seen the behavior you're describing. Can you provide a complete example, or an animated GIF? |
I'll show you. This fact is also happening in react-select-plus demo. When i enter the page the react-select-components require one click for focusing and then another click for collapsing |
Excuse me, i was wrong. The react-select-plus component requires double click for expanding. Not for collapsing. The react- select component requires a single click for expanding. Last but not least, in the react-select-plus demo the third component about the large city dataset is working fine without double click requirment. Maybe it's a property which is set by default into some value but i was not able to find it |
@alrms Ah, yes. I did a bisect, and it looks like this was introduced by an upstream change: JedWatson/react-select#1527 It's been since fixed in JedWatson/react-select, so that fix should carry over once I merge in the latest tagged release (probably later this week). |
As a workaround, you might want to consider setting |
A thanks for the quick response @TrevorBurnham :) Please keep me inform when you merge the latest tagged release so as to update my component via npm :) |
1.0.0-rc.4 has been published. |
@TrevorBurnham Hello again. I update my react-select-plus component from rc-4.0 to rc-5 version and the issue i opened was returned. Can you check it out? |
Thanks for using react-select!
If you are reporting an error please include a test case that demonstrates the issue you're reporting!
This is very helpful to maintainers in order to help us see the issue you're seeing.
Here is a Plunker you can fork that has react-select loaded and supports JSX syntax:
https://plnkr.co/edit/HTmtER9AMNcPoWhXV707?p=preview
You may also find the online Babel tool quite helpful if you wish to use ES6/ES7 syntax not yet supported by the browser you are using.
The text was updated successfully, but these errors were encountered: