Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

casadi 3.6.6 (new formula) #183139

Closed
wants to merge 1 commit into from
Closed

Conversation

jcarpent
Copy link
Contributor

@jcarpent jcarpent commented Sep 1, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Sep 1, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 1, 2024
@jcarpent jcarpent changed the title Casadi: add new formula casadi 3.6.6 (new formula) Sep 1, 2024
@jcarpent
Copy link
Contributor Author

jcarpent commented Sep 1, 2024

@carlocab When running brew audit --new casadi, I obtained this output:

casadi
  * Files were found with references to the Homebrew shims directory.
    The offending files are:
      include/casadi/config.h
      lib/libcasadi.3.7.dylib

I've checked, and it seems that the casadi library stores internally the path to the compiler.
It will be hard to change the original code to comply with this HomeBrew rule.
@carlocab What are your thoughts on this issue?

@carlocab
Copy link
Member

carlocab commented Sep 1, 2024

I think that formulae that reference the shims directory are likely to be broken in some way at runtime, so can't/shouldn't be packaged in Homebrew.

However, it's unlikely that this is impossible or even very difficult to fix -- you can grep this repository for references to shims for examples.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Sep 22, 2024
@chenrui333 chenrui333 added upstream issue An upstream issue report is needed audit failure CI fails while auditing the software labels Sep 22, 2024
casadi: add shim build patch

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 22, 2024
@github-actions github-actions bot removed the stale No recent activity label Sep 23, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Oct 14, 2024
@github-actions github-actions bot closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit failure CI fails while auditing the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue stale No recent activity upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants