Skip to content

Conversation

@Moisan
Copy link
Member

@Moisan Moisan commented Apr 9, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Following #19649, when trying to use the new PHP shebang in a Formula, with include Language::PHP::Shebang, it raises this error: uninitialized constant Language::PHP. Adding this include in formula.rb, it works as expected.

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Moisan!

@p-linnane p-linnane enabled auto-merge April 9, 2025 20:05
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Moisan!

@p-linnane p-linnane added this pull request to the merge queue Apr 10, 2025
Merged via the queue into Homebrew:master with commit 9709c4f Apr 10, 2025
38 checks passed
@Moisan Moisan deleted the formula_php_shebang branch April 18, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants