-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
language: add php shebang module #19649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
|
I do not like that Whalebrew Bundle test may not pass for an unknown reason |
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @botantony! Can you detail at least 3+ formulae the will use/need this?
|
Other formulae work fine but I still think it would be nice to explicitly define Homebrew's PHP in shebang. F.e.:
There are also formulae like |
What happens without this defined explicitly? |
|
If the formula is not compatible with the newest version yet (which happens with every new major PHP update) |
|
Here's an example from the core repository: |
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @botantony!
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?